From 0b85e45b7cf60512f36fc4b2880a576074d547d6 Mon Sep 17 00:00:00 2001
From: Alexis Poyen <apoyen@mail.apoyen.fr>
Date: Wed, 3 Jun 2020 14:05:49 +0200
Subject: [PATCH] Refactor : remove useless var and rename some

---
 web/components/management/area.js        | 4 ++--
 web/components/management/desk.js        | 3 +--
 web/components/management/election.js    | 4 ++--
 web/components/management/rounds-card.js | 5 ++---
 web/components/management/section.js     | 4 ++--
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/web/components/management/area.js b/web/components/management/area.js
index 12d1433..6508523 100644
--- a/web/components/management/area.js
+++ b/web/components/management/area.js
@@ -210,7 +210,7 @@ class Area {
     </div>`;
   }
 
-  async activateArea(area) {
+  async activateArea(areaToActivate) {
     this.parent.sectionHandler.emptySections();
     this.parent.deskHandler.emptyDesks();
     let areas = await this.updateAreas();
@@ -220,7 +220,7 @@ class Area {
         .classList.remove("active-card");
     });
     document
-      .getElementById(`areas-area-${area.ID}`)
+      .getElementById(`areas-area-${areaToActivate.ID}`)
       .classList.add("active-card");
   }
 
diff --git a/web/components/management/desk.js b/web/components/management/desk.js
index 9f6418a..ecddcca 100644
--- a/web/components/management/desk.js
+++ b/web/components/management/desk.js
@@ -242,7 +242,7 @@ class Desk {
           `Desk could not be updated or created (status ${response.status})`
         );
       }
-      desk = await response.json();
+      await response.json();
       await this.displayDesks();
     } catch (e) {
       Messages.Show("is-warning", e.message);
@@ -296,7 +296,6 @@ class Desk {
   }
 
   async cloneDesks(sectionCloned, sectionToClone) {
-    let deskHandler = this;
     await sectionToClone.Desks.forEach(async (deskToClone) => {
       try {
         const response = await fetch("/api/Desk/", {
diff --git a/web/components/management/election.js b/web/components/management/election.js
index 95fc3ec..508692e 100644
--- a/web/components/management/election.js
+++ b/web/components/management/election.js
@@ -291,7 +291,7 @@ class Election {
     </div>`;
   }
 
-  async activateElection(election) {
+  async activateElection(electionToActivate) {
     this.parent.areaHandler.emptyAreas();
     this.parent.sectionHandler.emptySections();
     this.parent.deskHandler.emptyDesks();
@@ -302,7 +302,7 @@ class Election {
         .classList.remove("active-card");
     });
     document
-      .getElementById(`elections-election-${election.ID}`)
+      .getElementById(`elections-election-${electionToActivate.ID}`)
       .classList.add("active-card");
   }
 
diff --git a/web/components/management/rounds-card.js b/web/components/management/rounds-card.js
index f1bbb7f..81dad98 100644
--- a/web/components/management/rounds-card.js
+++ b/web/components/management/rounds-card.js
@@ -155,7 +155,6 @@ class Round {
           roundHandler.editRound(round);
         });
       let election = await Getters.getElection(current_user, round.ElectionID);
-      let html = document.getElementById(`rounds-round-desc-${round.ID}`).innerHTML
       document.getElementById(`rounds-round-desc-${round.ID}`).innerHTML =
         election.Name +
         " " +
@@ -211,7 +210,7 @@ class Round {
     </div>`;
   }
 
-  async activateRound(round) {
+  async activateRound(roundToActivate) {
     // TODO unselect desks and candidateLists
     let rounds = await this.updateRounds();
     rounds.forEach((round) => {
@@ -220,7 +219,7 @@ class Round {
         .classList.remove("active-card");
     });
     document
-      .getElementById(`rounds-round-${round.ID}`)
+      .getElementById(`rounds-round-${roundToActivate.ID}`)
       .classList.add("active-card");
   }
 
diff --git a/web/components/management/section.js b/web/components/management/section.js
index 7f7c6e2..522db0f 100644
--- a/web/components/management/section.js
+++ b/web/components/management/section.js
@@ -212,7 +212,7 @@ class Section {
     </div>`;
   }
 
-  async activateSection(section) {
+  async activateSection(sectionToActivate) {
     this.parent.deskHandler.emptyDesks();
     let sections = await this.updateSections();
     sections.forEach((section) => {
@@ -221,7 +221,7 @@ class Section {
         .classList.remove("active-card");
     });
     document
-      .getElementById(`sections-section-${section.ID}`)
+      .getElementById(`sections-section-${sectionToActivate.ID}`)
       .classList.add("active-card");
   }
 
-- 
GitLab