From 240c318b206de5b7cbd8793a533293dd1af1235d Mon Sep 17 00:00:00 2001
From: Bastien Dumont <bdumont@grandlyon.com>
Date: Fri, 3 May 2024 15:47:57 +0200
Subject: [PATCH] chore: remove useless useCallback

---
 src/components/Consents/Consents.tsx     | 23 ++++++++++-------------
 src/components/Newsletter/Newsletter.tsx | 12 ++++++------
 src/components/Prices/PriceSection.tsx   | 16 ++++++++--------
 3 files changed, 24 insertions(+), 27 deletions(-)

diff --git a/src/components/Consents/Consents.tsx b/src/components/Consents/Consents.tsx
index 886f81cd..e2cd8fbf 100644
--- a/src/components/Consents/Consents.tsx
+++ b/src/components/Consents/Consents.tsx
@@ -35,9 +35,9 @@ export const Consents: React.FC<{ type: 'sge' | 'grdf' }> = ({ type }) => {
   const [totalRows, setTotalRows] = useState<number>(50)
   const { data: user } = useWhoAmI()
 
-  const toggleOpenModal = useCallback(() => {
+  const toggleOpenModal = () => {
     setOpenDownloadModal(prev => !prev)
-  }, [])
+  }
 
   const consentService = useMemo(
     () => (isGRDF ? new GrdfConsentService() : new SgeConsentService()),
@@ -57,19 +57,16 @@ export const Consents: React.FC<{ type: 'sge' | 'grdf' }> = ({ type }) => {
     [isGRDF]
   )
 
-  const handleChangePage = useCallback(
-    (
-      _event: React.MouseEvent<HTMLButtonElement, MouseEvent> | null,
-      newPage: number
-    ) => {
-      setPage(newPage)
-    },
-    []
-  )
-  const handleChangeRowsPerPage = useCallback((event: any) => {
+  const handleChangePage = (
+    _event: React.MouseEvent<HTMLButtonElement, MouseEvent> | null,
+    newPage: number
+  ) => {
+    setPage(newPage)
+  }
+  const handleChangeRowsPerPage = (event: any) => {
     setRowsPerPage(event.target.value)
     setPage(0)
-  }, [])
+  }
 
   const checkSelectedNodes = useCallback(() => {
     if (gridApi && !gridApi.isDestroyed()) {
diff --git a/src/components/Newsletter/Newsletter.tsx b/src/components/Newsletter/Newsletter.tsx
index 22d3f187..2143d28f 100644
--- a/src/components/Newsletter/Newsletter.tsx
+++ b/src/components/Newsletter/Newsletter.tsx
@@ -100,9 +100,9 @@ const Newsletter: React.FC = () => {
       setIsTouched(false)
     }
   }
-  const handleCancel = useCallback(() => {
+  const handleCancel = () => {
     setRefreshData(true)
-  }, [])
+  }
 
   const handleDeleteMailSubject = async (): Promise<void> => {
     if (user) {
@@ -110,7 +110,7 @@ const Newsletter: React.FC = () => {
         date,
         getAxiosXSRFHeader(user.xsrftoken)
       )
-      setRefreshData(true)
+      handleCancel()
     }
   }
   const handleDeleteMonthlyInfo = async (): Promise<void> => {
@@ -119,7 +119,7 @@ const Newsletter: React.FC = () => {
         date,
         getAxiosXSRFHeader(user.xsrftoken)
       )
-      setRefreshData(true)
+      handleCancel()
     }
   }
   const handleDeleteMonthlyNews = async (): Promise<void> => {
@@ -128,7 +128,7 @@ const Newsletter: React.FC = () => {
         date,
         getAxiosXSRFHeader(user.xsrftoken)
       )
-      setRefreshData(true)
+      handleCancel()
     }
   }
   const handleDeletePoll = async (): Promise<void> => {
@@ -137,7 +137,7 @@ const Newsletter: React.FC = () => {
         date,
         getAxiosXSRFHeader(user.xsrftoken)
       )
-      setRefreshData(true)
+      handleCancel()
     }
   }
   const handleOpenDeleteModal = (target: ContentItems) => {
diff --git a/src/components/Prices/PriceSection.tsx b/src/components/Prices/PriceSection.tsx
index 693d3424..708fa904 100644
--- a/src/components/Prices/PriceSection.tsx
+++ b/src/components/Prices/PriceSection.tsx
@@ -39,14 +39,14 @@ const PriceSection: React.FC<PriceSectionProps> = ({ fluid, frequency }) => {
   })
   const maxPerList = 8
 
-  const handlePriceSelection = useCallback((val: string) => {
+  const handlePriceSelection = (val: string) => {
     if (val === '') val = '0'
     val = val.replace(/,/g, '.')
     val = val.replace(/([^0-9.]+)/, '')
     setPriceToSave(prev => {
       return { ...prev, price: val }
     })
-  }, [])
+  }
 
   const savePrice = useCallback(async () => {
     if (
@@ -68,20 +68,20 @@ const PriceSection: React.FC<PriceSectionProps> = ({ fluid, frequency }) => {
     }
   }, [priceToSave, user])
 
-  const toggleHistory = useCallback(() => {
+  const toggleHistory = () => {
     setShowHistory(prev => !prev)
-  }, [])
+  }
 
-  const getDate = useCallback((isoString: string): string => {
+  const getDate = (isoString: string): string => {
     const date = new Date(isoString)
     const month = date.toLocaleString('fr', { month: 'long' })
     const year = date.toLocaleString('fr', { year: 'numeric' })
     return `${month} ${year}`
-  }, [])
+  }
 
-  const toggleFullList = useCallback(() => {
+  const toggleFullList = () => {
     setShowFullList(prev => !prev)
-  }, [])
+  }
 
   useEffect(() => {
     let subscribed = true
-- 
GitLab