From 0e7320a5847f679c1e66605b23146eb3fe382bcf Mon Sep 17 00:00:00 2001
From: Bastien DUMONT <bdumont@grandlyon.com>
Date: Mon, 22 Jan 2024 14:41:17 +0000
Subject: [PATCH] chore(gas): small refactor
---
.../PartnerConnectModal/Steps/GrdfFormOAuth.tsx | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/components/Connection/PartnerConnectModal/Steps/GrdfFormOAuth.tsx b/src/components/Connection/PartnerConnectModal/Steps/GrdfFormOAuth.tsx
index 828689ad0..aa598b45f 100644
--- a/src/components/Connection/PartnerConnectModal/Steps/GrdfFormOAuth.tsx
+++ b/src/components/Connection/PartnerConnectModal/Steps/GrdfFormOAuth.tsx
@@ -13,9 +13,6 @@ const GrdfFormOAuth = ({
}: {
onSuccess: (accountId: string) => Promise<void>
}) => {
- const IDLE = 'idle'
- const WAITING = 'waiting'
-
const { t } = useI18n()
const client = useClient()
const { shouldRefreshConsent, fluidStatus } = useAppSelector(
@@ -24,9 +21,9 @@ const GrdfFormOAuth = ({
const currentFluidStatus = fluidStatus[FluidType.GAS]
const konnector: Konnector | null = currentFluidStatus.connection.konnector
const dispatch = useAppDispatch()
- const [status, setStatus] = useState<string>(IDLE)
+ const [status, setStatus] = useState<'idle' | 'waiting'>('idle')
const endOAuth = useCallback(() => {
- setStatus(IDLE)
+ setStatus('idle')
// Set back to false the variable that allows to automatically refresh the consent (deletes and recreates the account)
dispatch(setShouldRefreshConsent(false))
}, [dispatch])
@@ -39,12 +36,12 @@ const GrdfFormOAuth = ({
[endOAuth, onSuccess]
)
- const isWaiting = status === WAITING
+ const isWaiting = status === 'waiting'
useEffect(() => {
if (shouldRefreshConsent) {
// If user has selected accept button on Expired consent modal, his account has been deleted on KonnectorViewerCard, such as his consent (for GRDF), then automatically launch oauth connection flow
- setStatus(WAITING)
+ setStatus('waiting')
}
}, [shouldRefreshConsent])
@@ -56,7 +53,7 @@ const GrdfFormOAuth = ({
<>
<Button
aria-label={t('auth.accessibility.button_connect')}
- onClick={() => setStatus(WAITING)}
+ onClick={() => setStatus('waiting')}
disabled={isWaiting}
className="btnPrimary"
>
--
GitLab