From 173892d7f9a2e40c6f3df1e5b41619f3f9272f62 Mon Sep 17 00:00:00 2001 From: Bastien Dumont <bdumont@grandlyon.com> Date: Wed, 3 Apr 2024 15:07:50 +0200 Subject: [PATCH] convert switch to ifs in render --- .../Konnector/KonnectorModalFooter.tsx | 142 +++++++++--------- 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/src/components/Konnector/KonnectorModalFooter.tsx b/src/components/Konnector/KonnectorModalFooter.tsx index f756531b4..2023ed972 100644 --- a/src/components/Konnector/KonnectorModalFooter.tsx +++ b/src/components/Konnector/KonnectorModalFooter.tsx @@ -46,88 +46,86 @@ const KonnectorModalFooter = ({ } }, [account, client, handleAccountDeletion, navigate]) - switch (error) { - case KonnectorError.USER_ACTION_NEEDED: - // INSEE CODE ERROR ENEDIS - return ( + if (error === KonnectorError.USER_ACTION_NEEDED) { + // INSEE CODE ERROR ENEDIS + return ( + <Button + aria-label={t('konnector_modal.accessibility.button_close')} + onClick={() => handleCloseClick(state === SUCCESS_EVENT)} + className="btnPrimary" + > + <div>{t('konnector_modal.button_understood')}</div> + </Button> + ) + } else if (error === KonnectorError.LOGIN_FAILED) { + // INCOMPLETE CONSENT FORM - GRDF // what is this comment ? + return ( + <Button + aria-label={t('konnector_modal.accessibility.button_close')} + onClick={() => handleCloseClick(state === SUCCESS_EVENT)} + className="btnPrimary" + > + <div>{t('konnector_modal.button_try_again')}</div> + </Button> + ) + } else if (error === KonnectorError.CHALLENGE_ASKED) { + return ( + <Button + aria-label={t('konnector_modal.accessibility.button_close')} + onClick={() => handleCloseClick(state === SUCCESS_EVENT)} + className="btnPrimary" + > + <div>{t('konnector_modal.button_come_back_later')}</div> + </Button> + ) + } else if (error === KonnectorError.TERMS_VERSION_MISMATCH) { + return ( + <div className="buttons"> <Button aria-label={t('konnector_modal.accessibility.button_close')} onClick={() => handleCloseClick(state === SUCCESS_EVENT)} - className="btnPrimary" - > - <div>{t('konnector_modal.button_understood')}</div> - </Button> - ) - case KonnectorError.LOGIN_FAILED: - // INCOMPLETE CONSENT FORM - GRDF // what is this comment ? - return ( - <Button - aria-label={t('konnector_modal.accessibility.button_close')} - onClick={() => handleCloseClick(state === SUCCESS_EVENT)} - className="btnPrimary" + className="btnSecondary" > - <div>{t('konnector_modal.button_try_again')}</div> + <div>{t('konnector_modal.button_later')}</div> </Button> - ) - case KonnectorError.CHALLENGE_ASKED: - return ( <Button aria-label={t('konnector_modal.accessibility.button_close')} - onClick={() => handleCloseClick(state === SUCCESS_EVENT)} - className="btnPrimary" - > - <div>{t('konnector_modal.button_come_back_later')}</div> - </Button> - ) - case KonnectorError.TERMS_VERSION_MISMATCH: - return ( - <div className="buttons"> - <Button - aria-label={t('konnector_modal.accessibility.button_close')} - onClick={() => handleCloseClick(state === SUCCESS_EVENT)} - className="btnSecondary" - > - <div>{t('konnector_modal.button_later')}</div> - </Button> - <Button - aria-label={t('konnector_modal.accessibility.button_close')} - onClick={!isUpdating ? handleSGELoginRetry : handleResetSGEAccount} - className="btnPrimary" - > - <div> - {!isUpdating - ? t('konnector_modal.button_check_info') - : t('konnector_modal.button_go')} - </div> - </Button> - </div> - ) - case KonnectorError.USER_ACTION_NEEDED_ACCOUNT_REMOVED: - return ( - <Button - aria-label={t('konnector_modal.accessibility.button_close')} - onClick={() => { - window.open( - `${__SAU_ISSUE_DIRECT_LINK__}?version=${client.appMetadata.version}` - ) - handleCloseClick(state === SUCCESS_EVENT) - }} - className="btnPrimary" - > - <div>{t('konnector_modal.button_contact')}</div> - </Button> - ) - default: - // DEFAULT FOOTER BUTTONS - return ( - <Button - aria-label={t('konnector_modal.accessibility.button_close')} - onClick={() => handleCloseClick(state === SUCCESS_EVENT)} + onClick={!isUpdating ? handleSGELoginRetry : handleResetSGEAccount} className="btnPrimary" > - <div>{t('konnector_modal.button_validate')}</div> + <div> + {!isUpdating + ? t('konnector_modal.button_check_info') + : t('konnector_modal.button_go')} + </div> </Button> - ) + </div> + ) + } else if (error === KonnectorError.USER_ACTION_NEEDED_ACCOUNT_REMOVED) { + return ( + <Button + aria-label={t('konnector_modal.accessibility.button_close')} + onClick={() => { + window.open( + `${__SAU_ISSUE_DIRECT_LINK__}?version=${client.appMetadata.version}` + ) + handleCloseClick(state === SUCCESS_EVENT) + }} + className="btnPrimary" + > + <div>{t('konnector_modal.button_contact')}</div> + </Button> + ) + } else { + return ( + <Button + aria-label={t('konnector_modal.accessibility.button_close')} + onClick={() => handleCloseClick(state === SUCCESS_EVENT)} + className="btnPrimary" + > + <div>{t('konnector_modal.button_validate')}</div> + </Button> + ) } } -- GitLab