From 74fc26aaaf49a7d46c73a6bcf35b785f12372c56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20PAILHAREY?= <rpailharey@grandlyon.com> Date: Thu, 1 Jun 2023 09:16:50 +0000 Subject: [PATCH] fix: division by zero in newsletter comparison --- src/services/consumption.service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services/consumption.service.ts b/src/services/consumption.service.ts index e3b2b4070..e92976296 100644 --- a/src/services/consumption.service.ts +++ b/src/services/consumption.service.ts @@ -247,8 +247,8 @@ export default class ConsumptionDataManager { private calculatePerformanceIndicatorVariationPercentage( dataSum: number, comparisonDataSum: number - ): number { - return dataSum / comparisonDataSum - 1 + ): number | null { + return comparisonDataSum !== 0 ? dataSum / comparisonDataSum - 1 : null } private async fetchSingleFluidGraphData( -- GitLab