diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md index 8c19cae9f4fd366b23f389beffde3bead1e3bb56..ba37698f819a73a0116bfccc7fc032e8bc9fb66e 100644 --- a/.gitlab/merge_request_templates/default.md +++ b/.gitlab/merge_request_templates/default.md @@ -30,36 +30,26 @@ More reading on checklists can be found in the "Checklist Manifesto": http://atu ### Quality [](https://sonarqube.forge.grandlyon.com/dashboard?id=ecolyo-mr) - [](https://sonarqube.forge.grandlyon.com/dashboard?id=ecolyo-mr) -* [ ] Confirmed - -1. For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR. -1. I have made sure that the sonar quality coverage is up to standards. -1. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied. -1. I have tested this MR in all supported browsers or determined that this testing is not needed. -1. I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply. +- For the code that this change impacts, I believe that the **automated tests validate functionality** that is **highly important to users**. If the existing automated tests do not cover this functionality, I have **added the necessary additional tests** or I have added an issue to describe the automation testing gap and linked it to this MR. +- I have made sure that the **sonar quality coverage is up to standards**. +- I have **considered the impact** of this change on the **front-end**, **back-end**, and **database** portions of the system where appropriate and applied. +- I have tested this MR in **all supported browsers** or determined that this testing is not needed. +- I have confirmed that this change is **backwards compatible** across updates (migrate up needs a migrate down), or I have decided that this does not apply. ### Performance, reliability and availability -* [ ] Confirmed - -1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact. -1. I have considered the scalability risk based on future predicted growth. +- I am confident that this MR **does not harm performance**, or I have asked a reviewer to help assess the performance impact. +- I have considered the **scalability risk** based on future predicted growth. ### Documentation -* [ ] Confirmed - -1. The MR is named after the desired squash commit to feed the changelog linked to the current milestone. -1. I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR. +- The MR is named after the **desired squash commit** to feed the changelog linked to the current milestone. +- I have **added/updated documentation** (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR. ### Security [](https://sonarqube.forge.grandlyon.com/dashboard?id=ecolyo-mr) -* [ ] Confirmed - -1. I have confirmed that if this MR does not contains any sensitive informations hidden in the changes. +- I have confirmed that if this MR **does not contains any sensitive informations** hidden in the changes. ### Deployment -* [ ] Confirmed - -1. When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy. +- When featured on a self-data project release, I have made sure my **app version** in the manifest and package.json is **incremented** and any relative **changes to the permissions are clearly written and transmitted to Cozy**.