From 97ef0bb66c59b9d884e5498a73ed822a51c2331a Mon Sep 17 00:00:00 2001
From: Yoan VALLET <ext.sopra.yvallet@grandlyon.com>
Date: Wed, 16 Dec 2020 09:44:36 +0100
Subject: [PATCH] feat: enhance isChallengeDone
---
src/services/challenge.service.ts | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/services/challenge.service.ts b/src/services/challenge.service.ts
index 479b73fb3..5ce53df8f 100644
--- a/src/services/challenge.service.ts
+++ b/src/services/challenge.service.ts
@@ -389,12 +389,9 @@ export default class ChallengeService {
const dataload = dataloads[duration - 1]
if (dataload.valueDetail) {
let completedValueDetail = true
- if (dataload.valueDetail) {
- dataload.valueDetail.forEach(value => {
- if (!value || (value && value === -1))
- completedValueDetail = false
- })
- }
+ dataload.valueDetail.forEach(value => {
+ if (!value || (value && value === -1)) completedValueDetail = false
+ })
if (completedValueDetail) {
isDone = true
}
--
GitLab