From a3db9cd7da0a7f164dbad6444b0d826eb781ed7c Mon Sep 17 00:00:00 2001
From: Bastien Dumont <bdumont@grandlyon.com>
Date: Wed, 29 Nov 2023 16:51:40 +0100
Subject: [PATCH] fix(duel): card height

---
 src/components/Challenge/ChallengeCard/ChallengeCard.tsx       | 3 ++-
 .../ChallengeCard/__snapshots__/ChallengeCard.spec.tsx.snap    | 2 +-
 src/components/Challenge/ChallengeCard/challengeCard.scss      | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/components/Challenge/ChallengeCard/ChallengeCard.tsx b/src/components/Challenge/ChallengeCard/ChallengeCard.tsx
index b8a5e9103..52248f325 100644
--- a/src/components/Challenge/ChallengeCard/ChallengeCard.tsx
+++ b/src/components/Challenge/ChallengeCard/ChallengeCard.tsx
@@ -42,13 +42,14 @@ const ChallengeCard = ({
   }
 
   return (
+    // eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
     <div
       onClick={() => moveToSlide(index)}
       className={indexSlider === index ? 'slide active' : 'slide inactive'}
       style={{
         minWidth: `${cardWidth}px`,
         maxWidth: `${cardWidth}px`,
-        height: `${cardHeight}px`,
+        minHeight: `${cardHeight}px`,
       }}
     >
       {renderCard(userChallenge)}
diff --git a/src/components/Challenge/ChallengeCard/__snapshots__/ChallengeCard.spec.tsx.snap b/src/components/Challenge/ChallengeCard/__snapshots__/ChallengeCard.spec.tsx.snap
index 457e83187..f0c8b96af 100644
--- a/src/components/Challenge/ChallengeCard/__snapshots__/ChallengeCard.spec.tsx.snap
+++ b/src/components/Challenge/ChallengeCard/__snapshots__/ChallengeCard.spec.tsx.snap
@@ -4,7 +4,7 @@ exports[`ChallengeCard component should be rendered correctly 1`] = `
 <div>
   <div
     class="slide active"
-    style="min-width: 200px; max-width: 200px; height: 400px;"
+    style="min-width: 200px; max-width: 200px; min-height: 400px;"
   >
     <div
       class="cardContent cardDone"
diff --git a/src/components/Challenge/ChallengeCard/challengeCard.scss b/src/components/Challenge/ChallengeCard/challengeCard.scss
index ac7c9ebca..c9133b2d6 100644
--- a/src/components/Challenge/ChallengeCard/challengeCard.scss
+++ b/src/components/Challenge/ChallengeCard/challengeCard.scss
@@ -23,5 +23,6 @@
     padding: 1rem;
     transition: all 300ms ease;
     border-radius: 4px;
+    flex: 1;
   }
 }
-- 
GitLab