From aa958e3b0a535b4556c91d566aba88500115d719 Mon Sep 17 00:00:00 2001
From: Romain CREY <ext.sopra.rcrey@grandlyon.com>
Date: Wed, 1 Jul 2020 10:18:27 +0200
Subject: [PATCH] fix: add subscribed on async useEffect
---
.../AvailableChallengeDetailsViewContainer.tsx | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/components/ContainerComponents/ViewContainer/AvailableChallengeDetailsViewContainer.tsx b/src/components/ContainerComponents/ViewContainer/AvailableChallengeDetailsViewContainer.tsx
index 27f268331..7152d937d 100644
--- a/src/components/ContainerComponents/ViewContainer/AvailableChallengeDetailsViewContainer.tsx
+++ b/src/components/ContainerComponents/ViewContainer/AvailableChallengeDetailsViewContainer.tsx
@@ -76,6 +76,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
}
useEffect(() => {
+ let subscribed = true
const lag = challengeManager.getLagDays(fluidTypes)
const timePeriod = {
@@ -94,7 +95,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
20,
fluidTypes
)
- if (fetchedPerformanceIndicators) {
+ if (fetchedPerformanceIndicators && subscribed) {
fetchedPerformanceIndicators.forEach(element => {
!element.value ? setLackOfDataForChallenge(true) : null
})
@@ -106,6 +107,9 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
if (props.location.state) {
setChallenge(props && props.location.state.challenge)
}
+ return () => {
+ subscribed = false
+ }
}, [])
return (
--
GitLab