From ac4b79775e6ee2a5f214500ec2309e17d7788ca0 Mon Sep 17 00:00:00 2001
From: gcarron <gcarron@grandlyon.com>
Date: Mon, 22 Feb 2021 15:04:42 +0100
Subject: [PATCH] Fix sonar issues
---
src/components/Challenge/challengeCardOnGoing.scss | 1 -
src/components/Challenge/challengeView.scss | 1 -
src/components/Connection/ModalGRDF.tsx | 4 +++-
src/components/Ecogesture/ecogestureList.scss | 1 -
src/services/queryRunner.service.spec.ts | 4 +---
5 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/components/Challenge/challengeCardOnGoing.scss b/src/components/Challenge/challengeCardOnGoing.scss
index 2b54c4989..3e6dad1d4 100644
--- a/src/components/Challenge/challengeCardOnGoing.scss
+++ b/src/components/Challenge/challengeCardOnGoing.scss
@@ -23,7 +23,6 @@
.smallCard {
outline: none;
border: none;
- display: block;
width: 100%;
background: linear-gradient(180deg, #323339 0%, #25262b 100%);
height: 24%;
diff --git a/src/components/Challenge/challengeView.scss b/src/components/Challenge/challengeView.scss
index bd9128e4b..d81273a86 100644
--- a/src/components/Challenge/challengeView.scss
+++ b/src/components/Challenge/challengeView.scss
@@ -42,7 +42,6 @@
font-size: 1.3rem;
}
.challengeIcon {
- margin-top: 8%;
width: 100%;
max-width: 180px;
margin: auto;
diff --git a/src/components/Connection/ModalGRDF.tsx b/src/components/Connection/ModalGRDF.tsx
index 8c3fe3100..d3b880142 100644
--- a/src/components/Connection/ModalGRDF.tsx
+++ b/src/components/Connection/ModalGRDF.tsx
@@ -30,7 +30,9 @@ const ModalGRDF: React.FC<ModalGRDFProps> = ({
const { screenType } = useSelector((state: AppStore) => state.ecolyo.global)
useEffect(() => {
- status && status === 'idle' && handleCloseClick
+ if (status && status === 'idle') {
+ handleCloseClick()
+ }
}, [status, handleCloseClick])
return (
<Modal handleCloseClick={handleCloseClick}>
diff --git a/src/components/Ecogesture/ecogestureList.scss b/src/components/Ecogesture/ecogestureList.scss
index 1ed78afbf..789f80911 100644
--- a/src/components/Ecogesture/ecogestureList.scss
+++ b/src/components/Ecogesture/ecogestureList.scss
@@ -48,7 +48,6 @@
}
.ecogestures {
font-size: 0.95rem;
- padding-left: 0.25rem;
text-transform: initial;
padding-left: 0.5rem;
&.opened {
diff --git a/src/services/queryRunner.service.spec.ts b/src/services/queryRunner.service.spec.ts
index 38f5cdad3..937b2398b 100644
--- a/src/services/queryRunner.service.spec.ts
+++ b/src/services/queryRunner.service.spec.ts
@@ -8,7 +8,6 @@ import mockClient from '../../test/__mocks__/client'
import { loadYearData } from '../../test/__mocks__/loadYearData.mock'
import { loadMonthData } from '../../test/__mocks__/loadMonthData.mock'
import { loadDayData } from '../../test/__mocks__/loadDayData.mock'
-import { loadHourData } from '../../test/__mocks__/loadHourData.mock'
import { loadMinuteData } from '../../test/__mocks__/loadMinuteData.mock'
describe('queryRunner service', () => {
@@ -256,8 +255,7 @@ describe('queryRunner service', () => {
valueDetail: null,
},
]
- const filteredData = [...loadMinuteData]
- filteredData.filter(
+ const filteredData = [...loadMinuteData].filter(
data => data.year === 2020 && data.month === 11 && data.day === 2
)
const mockQueryResult: QueryResult<DataloadEntity[]> = {
--
GitLab