From c37f35b0d111c9279506c7d370e87532593f26d6 Mon Sep 17 00:00:00 2001 From: Bastien DUMONT <bdumont@grandlyon.com> Date: Thu, 6 Apr 2023 12:06:15 +0000 Subject: [PATCH] chore: update mr template --- .gitlab/merge_request_templates/default.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md index 577c10722..bcaceee3e 100644 --- a/.gitlab/merge_request_templates/default.md +++ b/.gitlab/merge_request_templates/default.md @@ -1,5 +1,9 @@ -| :triangular_flag_on_post: Give your MR the same name that the desired squash commit. In doubt, check the conventional commit [doc](https://www.conventionalcommits.org/en/v1.0.0/).| +# Related to + +| :triangular_flag_on_post: Give your MR title the same name that the desired squash commit. In doubt, check the conventional commit [doc][conventional-commits]. examples | | --- | +| **feat(profile)**: add... | +| **fix(annuaire)**: remove... | ## What does this MR do and why? @@ -9,12 +13,12 @@ _Describe in detail what your merge request does and why._ _These are strongly recommended to assist reviewers and reduce the time to merge your change._ - ## How to set up and validate locally (or on alpha) _List all steps to set up and validate the changes on local environment._ ## MR acceptance checklist + _To be completed by the chosen reviewer._ <!--- @@ -24,10 +28,9 @@ More reading on checklists can be found in the "Checklist Manifesto": http://atu "It is common to misconceive how checklists function in complex lines of work. They are not comprehensive how-to guides, whether for building a skyscraper or getting a plane out of trouble. They are quick and simple tools aimed to buttress the skills of expert professionals." - Gawande, Atul. The Checklist Manifesto ---> - ### Quality [](https://sonarqube.forge.grandlyon.com/dashboard?id=ecolyo-mr) - [](https://sonarqube.forge.grandlyon.com/dashboard?id=ecolyo-mr) -- For the code that this change impacts, I believe that the **automated tests validate functionality** that is **highly important to users**. If the existing automated tests do not cover this functionality, I have **added the necessary additional tests** or I have added an issue to describe the automation testing gap and linked it to this MR. +- For the code that this change impacts, I believe that the **automated tests validate functionality** that is **highly important to users**. If the existing automated tests do not cover this functionality, I have **added the necessary additional tests** or I have added an issue to describe the automation testing gap and linked it to this MR. - I have made sure that the **sonar quality coverage is up to standards**. - I have **considered the impact** of this change on the **front-end**, **back-end**, and **database** portions of the system where appropriate and applied. - I have tested this MR in **all supported browsers** or determined that this testing is not needed. @@ -50,3 +53,6 @@ More reading on checklists can be found in the "Checklist Manifesto": http://atu ### Deployment - When featured on a self-data project release, I have made sure my **app version** in the manifest and package.json is **incremented** and any relative **changes to the permissions are clearly written and transmitted to Cozy**. + +[conventional-commits]: https://www.conventionalcommits.org/en/v1.0.0/ + -- GitLab