From fc55a98f51bf4c492b9e98087314b35861c74598 Mon Sep 17 00:00:00 2001
From: Bastien DUMONT <bdumont@grandlyon.com>
Date: Thu, 26 Sep 2024 06:54:42 +0000
Subject: [PATCH] chore: remove unused getOldFluidData
---
src/services/fluid.service.spec.ts | 141 -----------------------------
src/services/fluid.service.ts | 27 ------
2 files changed, 168 deletions(-)
diff --git a/src/services/fluid.service.spec.ts b/src/services/fluid.service.spec.ts
index 8de4bf3ba..542834342 100644
--- a/src/services/fluid.service.spec.ts
+++ b/src/services/fluid.service.spec.ts
@@ -529,145 +529,4 @@ describe('Fluid service', () => {
expect(fluidStatus[2].maintenance).toBeTruthy()
})
})
-
- describe('getOldFluidData method', () => {
- it('should return Electricity as old fluid', async () => {
- const mockFluidStatus: FluidStatus[] = [
- {
- fluidType: FluidType.ELECTRICITY,
- status: FluidState.DONE,
- maintenance: false,
- firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- connection: {
- konnector: konnectorsData[0],
- account: accountsData[0],
- trigger: triggersData[0],
- triggerState: triggerStateData,
- shouldLaunchKonnector: false,
- isUpdating: false,
- konnectorConfig: {
- name: 'Enedis',
- oauth: false,
- slug: FluidSlugType.ELECTRICITY,
- siteLink: 'https://mon-compte-client.enedis.fr/',
- activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
- },
- },
- },
- ]
- const result = await FluidService.getOldFluidData(mockFluidStatus)
- expect(result).toEqual([FluidType.ELECTRICITY])
- })
-
- it('should return empty array as lastdatadate < 5 days', async () => {
- const mockFluidStatus: FluidStatus[] = [
- {
- fluidType: FluidType.ELECTRICITY,
- status: FluidState.DONE,
- maintenance: false,
- firstDataDate: DateTime.local().minus({ day: 31 }).setZone('utc', {
- keepLocalTime: true,
- }),
- lastDataDate: DateTime.local().minus({ day: 1 }).setZone('utc', {
- keepLocalTime: true,
- }),
- connection: {
- konnector: konnectorsData[0],
- account: accountsData[0],
- trigger: triggersData[0],
- triggerState: triggerStateData,
- shouldLaunchKonnector: false,
- isUpdating: false,
- konnectorConfig: {
- name: 'Enedis',
- oauth: false,
- slug: FluidSlugType.ELECTRICITY,
- siteLink: 'https://mon-compte-client.enedis.fr/',
- activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
- },
- },
- },
- ]
- const result = await FluidService.getOldFluidData(mockFluidStatus)
- expect(result).toEqual([])
- })
-
- it('should return empty array as status is NOT_CONNECTED', async () => {
- const mockFluidStatus: FluidStatus[] = [
- {
- fluidType: FluidType.ELECTRICITY,
- status: FluidState.NOT_CONNECTED,
- maintenance: false,
- firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- connection: {
- konnector: konnectorsData[0],
- account: accountsData[0],
- trigger: triggersData[0],
- triggerState: triggerStateData,
- shouldLaunchKonnector: false,
- isUpdating: false,
- konnectorConfig: {
- name: 'Enedis',
- oauth: false,
- slug: FluidSlugType.ELECTRICITY,
- siteLink: 'https://mon-compte-client.enedis.fr/',
- activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
- },
- },
- },
- ]
- const result: FluidType[] =
- await FluidService.getOldFluidData(mockFluidStatus)
- expect(result).toEqual([])
- })
-
- it('should return empty array as status is KONNECTOR_NOT_FOUND', async () => {
- const mockFluidStatus: FluidStatus[] = [
- {
- fluidType: FluidType.ELECTRICITY,
- status: FluidState.KONNECTOR_NOT_FOUND,
- maintenance: false,
- firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
- keepLocalTime: true,
- }),
- connection: {
- konnector: konnectorsData[0],
- account: accountsData[0],
- trigger: triggersData[0],
- triggerState: triggerStateData,
- shouldLaunchKonnector: false,
- isUpdating: false,
- konnectorConfig: {
- name: 'Enedis',
- oauth: false,
- slug: FluidSlugType.ELECTRICITY,
- siteLink: 'https://mon-compte-client.enedis.fr/',
- activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
- },
- },
- },
- ]
- const result: FluidType[] =
- await FluidService.getOldFluidData(mockFluidStatus)
- expect(result).toEqual([])
- })
-
- it('should return empty array', async () => {
- const result: FluidType[] = await FluidService.getOldFluidData([])
- expect(result).toEqual([])
- })
- })
})
diff --git a/src/services/fluid.service.ts b/src/services/fluid.service.ts
index f22c17dc5..4cf603519 100644
--- a/src/services/fluid.service.ts
+++ b/src/services/fluid.service.ts
@@ -157,31 +157,4 @@ export default class FluidService {
]
return result
}
-
- /**
- * Return fluids with data older than 5 days
- */
- static getOldFluidData = async (
- fluidStatus: FluidStatus[]
- ): Promise<FluidType[]> => {
- const fluidOldData: FluidType[] = []
- if (fluidStatus.length > 0) {
- for (const fluid of fluidStatus) {
- let diffInDays = 0
- if (fluid?.lastDataDate) {
- const dateToCompare = fluid.lastDataDate
- diffInDays = dateToCompare.diffNow('days').toObject().days || 0
- if (
- diffInDays < -5 &&
- fluid.status !== FluidState.KONNECTOR_NOT_FOUND &&
- fluid.status !== FluidState.NOT_CONNECTED
- ) {
- !fluidOldData.includes(fluid.fluidType) &&
- fluidOldData.push(fluid.fluidType)
- }
- }
- }
- }
- return fluidOldData
- }
}
--
GitLab