From 9c23ab9863f5b0a0946118dcf4dc305621567f14 Mon Sep 17 00:00:00 2001
From: Bastien Dumont <bdumont@grandlyon.com>
Date: Mon, 20 Mar 2023 15:16:01 +0100
Subject: [PATCH] rename parameters to lastname

---
 src/core/contractActivation.js |  6 +++---
 src/core/findUserPdl.js        |  6 +++---
 src/helpers/parsing.js         |  2 +-
 src/requests/sge.js            | 14 +++++++-------
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/core/contractActivation.js b/src/core/contractActivation.js
index aa24d51..fcb3fb9 100644
--- a/src/core/contractActivation.js
+++ b/src/core/contractActivation.js
@@ -10,7 +10,7 @@ const Sentry = require('@sentry/node')
  * @param {string} url
  * @param {string} apiAuthKey
  * @param {string} appLogin
- * @param {string} name
+ * @param {string} lastname
  * @param {number} pointId
  * @param {string} startDate
  * @param {string} endDate
@@ -21,7 +21,7 @@ async function activateContract(
   apiAuthKey,
   appLogin,
   contractId,
-  name,
+  lastname,
   pointId,
   startDate,
   endDate
@@ -39,7 +39,7 @@ async function activateContract(
       appLogin,
       contractId,
       pointId,
-      name,
+      lastname,
       startDate,
       endDate
     ),
diff --git a/src/core/findUserPdl.js b/src/core/findUserPdl.js
index 7b41735..4af3a6d 100644
--- a/src/core/findUserPdl.js
+++ b/src/core/findUserPdl.js
@@ -10,7 +10,7 @@ const Sentry = require('@sentry/node')
  * @param {string} url
  * @param {string} apiAuthKey
  * @param {string} appLogin
- * @param {string} name
+ * @param {string} lastname
  * @param {string} address
  * @param {string} postalCode
  * @param {string} inseeCode
@@ -20,7 +20,7 @@ async function findUserPdl(
   url,
   apiAuthKey,
   appLogin,
-  name,
+  lastname,
   address,
   postalCode,
   inseeCode,
@@ -37,7 +37,7 @@ async function findUserPdl(
     headers: sgeHeaders,
     xml: rechercherPoint(
       appLogin,
-      name,
+      lastname,
       postalCode,
       inseeCode,
       address,
diff --git a/src/helpers/parsing.js b/src/helpers/parsing.js
index dcb9532..d1c4638 100644
--- a/src/helpers/parsing.js
+++ b/src/helpers/parsing.js
@@ -114,7 +114,7 @@ function checkContractExists(parsedReply) {
 }
 
 /**
- * Format tag in order to be manipulated easly
+ * Format tag in order to be manipulated easily
  * @param {string} name
  * @returns {string} name
  */
diff --git a/src/requests/sge.js b/src/requests/sge.js
index 9fc48f6..41599dc 100644
--- a/src/requests/sge.js
+++ b/src/requests/sge.js
@@ -126,7 +126,7 @@ function consulterDonneesTechniquesContractuelles(
 
 /**
  * Use rechercherPoint to find user PDL if exist
- * @param {string} name
+ * @param {string} lastname
  * @param {string} postalCode
  * @param {string} inseeCode
  * @param {string} address
@@ -135,7 +135,7 @@ function consulterDonneesTechniquesContractuelles(
  */
 function rechercherPoint(
   appLogin,
-  name,
+  lastname,
   postalCode,
   inseeCode,
   address,
@@ -160,7 +160,7 @@ function rechercherPoint(
                    <codePostal>${postalCode}</codePostal>
                    <codeInseeCommune>${inseeCode}</codeInseeCommune>
                 </adresseInstallation>
-                <nomClientFinalOuDenominationSociale>${name}</nomClientFinalOuDenominationSociale>
+                <nomClientFinalOuDenominationSociale>${lastname}</nomClientFinalOuDenominationSociale>
                 <rechercheHorsPerimetre>true</rechercheHorsPerimetre>
              </criteres>
              <loginUtilisateur>${appLogin}</loginUtilisateur>
@@ -181,7 +181,7 @@ function rechercherPoint(
                  <codePostal>${postalCode}</codePostal>
                  <codeInseeCommune>${inseeCode}</codeInseeCommune>
               </adresseInstallation>
-              <nomClientFinalOuDenominationSociale>${name}</nomClientFinalOuDenominationSociale>
+              <nomClientFinalOuDenominationSociale>${lastname}</nomClientFinalOuDenominationSociale>
               <rechercheHorsPerimetre>true</rechercheHorsPerimetre>
            </criteres>
            <loginUtilisateur>${appLogin}</loginUtilisateur>
@@ -221,7 +221,7 @@ function rechercherServicesSouscritsMesures(appLogin, contractId, pointId) {
  * @param {string} appLogin
  * @param {string} contractId
  * @param {number} pointId
- * @param {string} name
+ * @param {string} lastname
  * @param {string} startDate
  * @param {string} endDate
  * @returns {*}
@@ -230,7 +230,7 @@ function commanderCollectePublicationMesures(
   appLogin,
   contractId,
   pointId,
-  name,
+  lastname,
   startDate,
   endDate
 ) {
@@ -258,7 +258,7 @@ function commanderCollectePublicationMesures(
                       <declarationAccordClient>
                           <accord>true</accord>
                           <personnePhysique>
-                              <nom>${name}</nom>
+                              <nom>${lastname}</nom>
                           </personnePhysique>
                       </declarationAccordClient>
                       <mesuresTypeCode>CDC</mesuresTypeCode>
-- 
GitLab