From a9f7434733d027573c73306fcfa90187f5a86651 Mon Sep 17 00:00:00 2001
From: Bastien DUMONT <bdumont@grandlyon.com>
Date: Wed, 3 Aug 2022 11:37:59 +0200
Subject: [PATCH] feat: findUserPdl throws login failed
---
src/findUserPdl.js | 9 ++++++---
src/index.js | 3 +--
src/verifyUserIdentity.js | 1 -
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/findUserPdl.js b/src/findUserPdl.js
index 3fbeabf..d1bfb11 100644
--- a/src/findUserPdl.js
+++ b/src/findUserPdl.js
@@ -6,7 +6,7 @@ const { rechercherPoint } = require('./requests/sge')
const xml2js = require('xml2js')
/**
- * @return {Promise<string>} User Pdl
+ * @return {Promise<string | null>} User Pdl
*/
async function findUserPdl(
url,
@@ -38,8 +38,11 @@ async function findUserPdl(
explicitArray: false,
})
- //TODO: handle errors
- return parseUserPdl(parsedReply)
+ try {
+ return parseUserPdl(parsedReply)
+ } catch (error) {
+ throw errors.LOGIN_FAILED
+ }
}
module.exports = { findUserPdl }
diff --git a/src/index.js b/src/index.js
index 0eda9de..e781bc8 100644
--- a/src/index.js
+++ b/src/index.js
@@ -32,8 +32,7 @@ const {
getBoConsent,
deleteBoConsent,
} = require('./requests/bo')
-
-const verifyUserIdentity = require('./verifyUserIdentity')
+const { verifyUserIdentity } = require('./verifyUserIdentity')
moment.locale('fr') // set the language
moment.tz.setDefault('Europe/Paris') // set the timezone
diff --git a/src/verifyUserIdentity.js b/src/verifyUserIdentity.js
index d0ef44a..bd62525 100644
--- a/src/verifyUserIdentity.js
+++ b/src/verifyUserIdentity.js
@@ -28,7 +28,6 @@ async function verifyUserIdentity(
inseeCode
)
console.log(pdl)
- console.log(fields.pointId)
if (fields.pointId != pdl) {
log('error', 'PointId does not match')
--
GitLab