From 3c6c67345ad9aebef6485907a69cc8c874b73654 Mon Sep 17 00:00:00 2001
From: Jeremie BRISON <ext.sopra.jbrison@grandlyon.com>
Date: Thu, 4 Feb 2021 19:02:04 +0100
Subject: [PATCH] fix(form) : clean code
---
.../address-autocomplete.component.html | 2 +-
.../address-autocomplete.component.ts | 8 ++++----
.../components/checkbox-form/checkbox-form.component.ts | 2 +-
.../hour-picker/copy-paste/copy-paste.component.ts | 6 +++---
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/app/shared/components/address-autocomplete/address-autocomplete.component.html b/src/app/shared/components/address-autocomplete/address-autocomplete.component.html
index 043c1c0e6..82ccf794d 100644
--- a/src/app/shared/components/address-autocomplete/address-autocomplete.component.html
+++ b/src/app/shared/components/address-autocomplete/address-autocomplete.component.html
@@ -10,7 +10,7 @@
#searchAddress
/>
</div>
- <div class="autocomplete-items" *ngIf="!isAlreadySearch">
+ <div class="autocomplete-items" *ngIf="!isAlreadySearching">
<p *ngFor="let hit of data" (click)="selectedResult(hit)" class="autocomplete-item">
{{ parseHitToAddress(hit) }}
</p>
diff --git a/src/app/shared/components/address-autocomplete/address-autocomplete.component.ts b/src/app/shared/components/address-autocomplete/address-autocomplete.component.ts
index 40dd0dd31..5bfb99bbf 100644
--- a/src/app/shared/components/address-autocomplete/address-autocomplete.component.ts
+++ b/src/app/shared/components/address-autocomplete/address-autocomplete.component.ts
@@ -10,7 +10,7 @@ import { AddressService } from '../../service/address.service';
export class AddressAutocompleteComponent implements OnInit {
public readonly AUTOCOMPLETE_NBR = 5;
public data = [];
- public isAlreadySearch = false;
+ public isAlreadySearching = false;
@ViewChild('searchAddress', { static: true }) searchAddress: ElementRef;
@Output() selectedAddress: EventEmitter<Address> = new EventEmitter<Address>();
@Output() inputAddress: EventEmitter<any> = new EventEmitter<any>();
@@ -25,11 +25,11 @@ export class AddressAutocompleteComponent implements OnInit {
}
}
public onSearchChange(searchString: string) {
- if (!this.isAlreadySearch) {
- this.isAlreadySearch = true;
+ if (!this.isAlreadySearching) {
+ this.isAlreadySearching = true;
this.addressService.searchAddress(searchString).subscribe((data) => {
this.data = data.hits.hits.slice(0, this.AUTOCOMPLETE_NBR);
- this.isAlreadySearch = false;
+ this.isAlreadySearching = false;
});
}
this.inputAddress.emit();
diff --git a/src/app/shared/components/checkbox-form/checkbox-form.component.ts b/src/app/shared/components/checkbox-form/checkbox-form.component.ts
index 92d7b4977..ef22ca374 100644
--- a/src/app/shared/components/checkbox-form/checkbox-form.component.ts
+++ b/src/app/shared/components/checkbox-form/checkbox-form.component.ts
@@ -15,7 +15,7 @@ export class CheckboxFormComponent implements OnInit {
ngOnInit(): void {}
- clicked() {
+ public clicked(): void {
this.isChecked = !this.isChecked;
this.checkEvent.emit(this.isChecked);
}
diff --git a/src/app/shared/components/hour-picker/copy-paste/copy-paste.component.ts b/src/app/shared/components/hour-picker/copy-paste/copy-paste.component.ts
index 6a63223ca..9240f96d1 100644
--- a/src/app/shared/components/hour-picker/copy-paste/copy-paste.component.ts
+++ b/src/app/shared/components/hour-picker/copy-paste/copy-paste.component.ts
@@ -16,15 +16,15 @@ export class CopyPasteComponent implements OnInit {
ngOnInit(): void {}
- public copy() {
+ public copy(): void {
this.copyEvent.emit(this.day);
}
- public paste() {
+ public paste(): void {
this.pasteEvent.emit(this.day);
}
- public cancel() {
+ public cancel(): void {
this.cancelEvent.emit();
}
}
--
GitLab