From 49e7d00c1cdd118fee2d5448c77f18b63a569b78 Mon Sep 17 00:00:00 2001
From: Jeremie BRISON <ext.sopra.jbrison@grandlyon.com>
Date: Fri, 12 Mar 2021 11:40:39 +0100
Subject: [PATCH] fix(sonar) : fix sonar bug
---
src/app/post/components/post-card/post-card.component.html | 2 +-
.../post/components/post-details/post-details.component.html | 2 +-
.../post/components/post-details/post-details.component.scss | 2 +-
.../post/components/post-publish/post-publish.component.scss | 2 +-
src/app/profile/profile.component.html | 2 +-
src/app/shared/components/button/button.component.scss | 1 -
6 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/app/post/components/post-card/post-card.component.html b/src/app/post/components/post-card/post-card.component.html
index 1db7cd7e0..78a4c3ef0 100644
--- a/src/app/post/components/post-card/post-card.component.html
+++ b/src/app/post/components/post-card/post-card.component.html
@@ -16,7 +16,7 @@
<span>{{ post.tags[0].name }}</span>
</div>
<div fxLayout="row" class="imageContainer" *ngIf="post.feature_image">
- <img class="image" [src]="post.feature_image" />
+ <img class="image" alt="image about the news" [src]="post.feature_image" />
</div>
<div fxLayout="row" class="title">
{{ post.title }}
diff --git a/src/app/post/components/post-details/post-details.component.html b/src/app/post/components/post-details/post-details.component.html
index 2e2136a31..dee0903ee 100644
--- a/src/app/post/components/post-details/post-details.component.html
+++ b/src/app/post/components/post-details/post-details.component.html
@@ -29,7 +29,7 @@
<div fxLayout="row">par {{ post.author }}</div>
</div>
<div fxLayout="row" class="imageContainer" *ngIf="post.feature_image">
- <img class="image" [src]="post.feature_image" />
+ <img class="image" alt="image about the news" [src]="post.feature_image" />
</div>
<div fxLayout="row" class="description">
<div [innerHtml]="post.safeHtml"></div>
diff --git a/src/app/post/components/post-details/post-details.component.scss b/src/app/post/components/post-details/post-details.component.scss
index 496864352..1adbe3606 100644
--- a/src/app/post/components/post-details/post-details.component.scss
+++ b/src/app/post/components/post-details/post-details.component.scss
@@ -10,7 +10,7 @@ $margin-post: 20px;
max-width: 832px;
margin: $margin-post auto;
min-height: calc(
- var(--vh, 1vh) * 100 - #{$header-height} - #{$footer-height} - #{$header-post-height} - #{$margin-post}* 3
+ var(--vh, 1vh) * 100 - #{$header-height} - #{$footer-height} - #{$header-post-height} - #{$margin-post} * 3
);
.chevronLeft {
height: 24px;
diff --git a/src/app/post/components/post-publish/post-publish.component.scss b/src/app/post/components/post-publish/post-publish.component.scss
index 8c66547d0..05cb307a7 100644
--- a/src/app/post/components/post-publish/post-publish.component.scss
+++ b/src/app/post/components/post-publish/post-publish.component.scss
@@ -9,7 +9,7 @@ $margin-post: 20px;
width: 95%;
margin: $margin-post auto;
min-height: calc(
- var(--vh, 1vh) * 100 - #{$header-height} - #{$footer-height} - #{$header-post-height} - #{$margin-post}* 2
+ var(--vh, 1vh) * 100 - #{$header-height} - #{$footer-height} - #{$header-post-height} - #{$margin-post} * 2
);
}
.chevronLeft {
diff --git a/src/app/profile/profile.component.html b/src/app/profile/profile.component.html
index 45f184ad1..66be72664 100644
--- a/src/app/profile/profile.component.html
+++ b/src/app/profile/profile.component.html
@@ -2,7 +2,7 @@
<div class="profileSection">
<div class="section-container" fxLayout="row">
<ng-container *ngIf="userProfile.profileImage">
- <img class="cameraProfile" src="userProfile.profileImage">
+ <img class="cameraProfile" alt="image of profile" src="userProfile.profileImage" />
</ng-container>
<div class="profileInformation" fxLayoutGap="18px" fxLayout="column">
<div fxLayout="row" fxLayoutAlign="space-between center">
diff --git a/src/app/shared/components/button/button.component.scss b/src/app/shared/components/button/button.component.scss
index 04a71d547..4cea9a735 100644
--- a/src/app/shared/components/button/button.component.scss
+++ b/src/app/shared/components/button/button.component.scss
@@ -48,7 +48,6 @@ button {
border-radius: 4px;
@include btn-bold;
font-size: 16px;
- border-radius: 4px;
&.withIcon {
color: $black;
height: 36px;
--
GitLab