From ad2a7c734e84ad2bd75d7b5665ce472012ce1d52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marl=C3=A8ne=20SIMONDANT?= <msimondant@grandlyon.com> Date: Tue, 13 Aug 2024 09:03:18 +0000 Subject: [PATCH] fix(accessibility): no duplicate ids for textarea fields --- .../select-or-create/select-or-create.component.html | 2 ++ src/app/shared/components/textarea/textarea.component.html | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/shared/components/select-or-create/select-or-create.component.html b/src/app/shared/components/select-or-create/select-or-create.component.html index 67aad1246..9e84c456d 100644 --- a/src/app/shared/components/select-or-create/select-or-create.component.html +++ b/src/app/shared/components/select-or-create/select-or-create.component.html @@ -5,6 +5,7 @@ size="large" [placeholder]="'exemple : ' + name.toLowerCase()" [label]="name" + [id]="'select-' + name.toLowerCase()" [wide]="true" [disabled]="isAddingNewItem" [status]="!isAddingNewItem ? (isSelectedItem ? 'success' : 'error') : null" @@ -39,6 +40,7 @@ <app-input autocomplete="off" size="large" + [id]="'create-' + name.toLowerCase()" [label]="'Nom de ' + (isFeminineWord ? 'la ' : 'l\'') + (name | lowercase)" [placeholder]="'exemple : ' + name.toLowerCase()" [description]="'Renseignez le nom de votre ' + name.toLowerCase()" diff --git a/src/app/shared/components/textarea/textarea.component.html b/src/app/shared/components/textarea/textarea.component.html index 2c3494407..1cc8cec25 100644 --- a/src/app/shared/components/textarea/textarea.component.html +++ b/src/app/shared/components/textarea/textarea.component.html @@ -1,12 +1,12 @@ <div class="inputContainer" [ngClass]="{ disabled: disabled }"> - <label [htmlFor]="id" [ngClass]="status">{{ label }}</label> + <label [htmlFor]="'textarea-' + id" [ngClass]="status">{{ label }}</label> <span *ngIf="description" class="description" [ngClass]="{ disabled: disabled }">{{ description }}</span> <textarea rows="8" [value]="value" [maxLength]="maxLength" - [id]="id" + [id]="'textarea-' + id" [disabled]="disabled" [ngClass]="status" [placeholder]="placeholder" -- GitLab