From fc8702287f26c859d4c3bfb449a9f771b9445bda Mon Sep 17 00:00:00 2001
From: Hugo SUBTIL <ext.sopra.husubtil@grandlyon.com>
Date: Fri, 11 Dec 2020 09:57:26 +0100
Subject: [PATCH] fix: unnecessary form validation and function return type
---
src/app/header/header.component.ts | 2 +-
src/app/services/auth.service.ts | 2 +-
.../shared/components/signin-modal/signin-modal.component.ts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/app/header/header.component.ts b/src/app/header/header.component.ts
index 5b8d6e7c7..cceb2dcf1 100644
--- a/src/app/header/header.component.ts
+++ b/src/app/header/header.component.ts
@@ -26,7 +26,7 @@ export class HeaderComponent implements OnInit {
}
public logout(): void {
- return this.authService.logout();
+ this.authService.logout();
}
public closeSignInModal(): void {
diff --git a/src/app/services/auth.service.ts b/src/app/services/auth.service.ts
index 113cb04be..0785f4e2f 100644
--- a/src/app/services/auth.service.ts
+++ b/src/app/services/auth.service.ts
@@ -37,7 +37,7 @@ export class AuthService {
return false;
}
- public getExpiration(): void {
+ public getExpiration(): DateTime {
return DateTime.fromISO(this.userValue.expires_at, { zone: 'Europe/Paris' });
}
diff --git a/src/app/shared/components/signin-modal/signin-modal.component.ts b/src/app/shared/components/signin-modal/signin-modal.component.ts
index 33996e503..253ec9136 100644
--- a/src/app/shared/components/signin-modal/signin-modal.component.ts
+++ b/src/app/shared/components/signin-modal/signin-modal.component.ts
@@ -29,7 +29,7 @@ export class SignInModalComponent implements OnInit {
'',
[Validators.required, Validators.pattern(/^(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])(?=.*[!@#$%^&*])(?=.{8,})/)],
],
- confirmPassword: ['', [Validators.required, Validators.minLength(8)]],
+ confirmPassword: [''],
},
{ validator: MustMatch('password', 'confirmPassword') }
);
--
GitLab