From e4f239ae4168721d013263d7fe124fe46941407d Mon Sep 17 00:00:00 2001
From: Marlene Simondant <msimondant@grandlyon.com>
Date: Thu, 8 Aug 2024 16:35:38 +0200
Subject: [PATCH 1/2] fix(accessibility): focus on news tabs in firefox
---
src/app/post/components/post-header/post-header.component.scss | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/app/post/components/post-header/post-header.component.scss b/src/app/post/components/post-header/post-header.component.scss
index 4de72a4ef..eb5a05e08 100644
--- a/src/app/post/components/post-header/post-header.component.scss
+++ b/src/app/post/components/post-header/post-header.component.scss
@@ -37,6 +37,7 @@ nav {
align-items: center;
border-bottom: 3px solid transparent;
transition: all 0.3s ease-in-out;
+ outline-offset: -2px; // fixes focus display in firefox that is was visible due to the "overflow-x" on .navigation
&.active {
@include font-bold-16;
border-color: $grey-1;
--
GitLab
From 603eb188e9ec91512c3b8a68b5120d12adb18e47 Mon Sep 17 00:00:00 2001
From: Marlene Simondant <msimondant@grandlyon.com>
Date: Thu, 8 Aug 2024 16:38:12 +0200
Subject: [PATCH 2/2] better comment
---
src/app/post/components/post-header/post-header.component.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/app/post/components/post-header/post-header.component.scss b/src/app/post/components/post-header/post-header.component.scss
index eb5a05e08..c934ed5f4 100644
--- a/src/app/post/components/post-header/post-header.component.scss
+++ b/src/app/post/components/post-header/post-header.component.scss
@@ -37,7 +37,7 @@ nav {
align-items: center;
border-bottom: 3px solid transparent;
transition: all 0.3s ease-in-out;
- outline-offset: -2px; // fixes focus display in firefox that is was visible due to the "overflow-x" on .navigation
+ outline-offset: -2px; // Fixes the focus display issue in Firefox where it was not visible due to "overflow-x" on .navigation
&.active {
@include font-bold-16;
border-color: $grey-1;
--
GitLab