From 33381037bed271fafe66618ca48412606dda3cc5 Mon Sep 17 00:00:00 2001
From: Etienne LOUPIAS <eloupias@grandlyon.com>
Date: Tue, 21 Mar 2023 15:44:46 +0100
Subject: [PATCH] fix(newsletter): add message for fake email
---
src/newsletter/newsletter.service.ts | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/newsletter/newsletter.service.ts b/src/newsletter/newsletter.service.ts
index 984de7a39..c6f2e752c 100644
--- a/src/newsletter/newsletter.service.ts
+++ b/src/newsletter/newsletter.service.ts
@@ -63,8 +63,12 @@ export class NewsletterService {
}
return newsletterSubscription;
} catch (e) {
- this.logger.error(`newsletterSubscribe ${email}: ${JSON.stringify(e)}`);
- throw new HttpException('Subscribe error', HttpStatus.INTERNAL_SERVER_ERROR);
+ if (e.status === 400 && e.response?.text?.includes('fake')) {
+ throw new HttpException('Fake or invalid email', HttpStatus.I_AM_A_TEAPOT);
+ } else {
+ this.logger.error(`newsletterSubscribe ${email}: ${JSON.stringify(e)}`);
+ throw new HttpException('Subscribe error', HttpStatus.INTERNAL_SERVER_ERROR);
+ }
}
}
--
GitLab