From eb8b24330f0380eecb1cad762c18f1cd8f6ce1b6 Mon Sep 17 00:00:00 2001
From: Hugo SUBTIL <ext.sopra.husubtil@grandlyon.com>
Date: Wed, 27 Jan 2021 11:43:30 +0100
Subject: [PATCH] fix: configuration logs and bug fix for user registration
---
src/configuration/configuration.service.ts | 6 +++---
src/structures/services/structures.service.ts | 2 +-
src/users/users.service.ts | 1 -
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/configuration/configuration.service.ts b/src/configuration/configuration.service.ts
index 35510efa4..f78dfe081 100644
--- a/src/configuration/configuration.service.ts
+++ b/src/configuration/configuration.service.ts
@@ -8,13 +8,13 @@ export class ConfigurationService {
constructor() {
// Initializing conf with values from var env
- if (process.env.NODE_ENV === 'production') {
+ if (process.env.NODE_ENV && process.env.NODE_ENV === 'production') {
this._config = configProd;
Logger.log('App started with production conf', 'ConfigurationService');
- } else if (process.env.NODE_ENV === 'dev') {
+ } else if (process.env.NODE_ENV && process.env.NODE_ENV === 'dev') {
this._config = configDev;
Logger.log('App started with dev conf', 'ConfigurationService');
- } else {
+ } else if (process.env.NODE_ENV) {
this._config = config;
Logger.log('App started with local conf', 'ConfigurationService');
}
diff --git a/src/structures/services/structures.service.ts b/src/structures/services/structures.service.ts
index 6c979e6ef..3d045c107 100644
--- a/src/structures/services/structures.service.ts
+++ b/src/structures/services/structures.service.ts
@@ -237,7 +237,7 @@ export class StructuresService {
structure.gender = '';
return structure;
}
-
+
@Cron(CronExpression.EVERY_DAY_AT_4AM)
public async checkOutdatedStructuresInfo(): Promise<void> {
const OUTDATED_MONT_TO_CHECK = 6;
diff --git a/src/users/users.service.ts b/src/users/users.service.ts
index ecdb28641..ca6bdc488 100644
--- a/src/users/users.service.ts
+++ b/src/users/users.service.ts
@@ -37,7 +37,6 @@ export class UsersService {
// Send verification email
createUser = await this.verifyUserMail(createUser);
createUser.save();
- this.sendAdminStructureValidationMail();
return await this.findOne(createUserDto.email);
}
--
GitLab