diff --git a/src/app/core/components/feedback/feedback.component.ts b/src/app/core/components/feedback/feedback.component.ts index 89abd60d641ee23057d8b366871ce92a87d627d6..49ad24e5064dc5fb6ad5a015484f358bf3b2e0ac 100644 --- a/src/app/core/components/feedback/feedback.component.ts +++ b/src/app/core/components/feedback/feedback.component.ts @@ -61,7 +61,10 @@ export class FeedbackComponent implements OnInit { this.feedbackForm.get('email').valueChanges.subscribe( (emailValue) => { - emailValue === '' || emailValue === null ? consent.setValue(false) : null; + if (emailValue === '' || emailValue === null ) { + consent.setValue(false); + } + if (emailValue !== null && emailValue !== '') { consent.setValidators([Validators.requiredTrue]); } else { @@ -115,7 +118,12 @@ export class FeedbackComponent implements OnInit { } get feedbackHasEmail() { - return this.feedbackForm.get('email').value && this.feedbackForm.get('email').value; + if (this.feedbackForm.get('email').value !== null && this.feedbackForm.get('email').value !== '') { + return true; + } + else { + return false; + } } get shouldAnimateClosing() { diff --git a/src/app/dataset-detail/components/dataset-table/dataset-table.component.html b/src/app/dataset-detail/components/dataset-table/dataset-table.component.html index c23a32389b52eadd57bc68a93295ffa235366461..72108716e5c10f0fc678096a3053fe15c32e87ef 100644 --- a/src/app/dataset-detail/components/dataset-table/dataset-table.component.html +++ b/src/app/dataset-detail/components/dataset-table/dataset-table.component.html @@ -6,10 +6,10 @@ (keydown.enter)="sortBy(key)" [tabindex]="isDisplayed ? 0 : -1" [attr.role]="'columnheader'"> <span class="sort-icons"> <span class="icon"> - <span class="fas fa-sort-up" [ngClass]="{'icon-red': sortValue === key && sortOrder === 'desc'}"></span > + <span class="fas fa-sort-up" [ngClass]="{'icon-red': sortValue.includes(key) && sortOrder === 'desc'}"></span> </span> <span class="icon"> - <span class="fas fa-sort-down" [ngClass]="{'icon-red': sortValue === key && sortOrder === 'asc'}"></span > + <span class="fas fa-sort-down" [ngClass]="{'icon-red': sortValue.includes(key) && sortOrder === 'asc'}"></span> </span> </span> <span class="column-title" [ngClass]="{'active': sortValue === key}">{{ key }}</span> diff --git a/src/app/user/components/user-profil/user-info/user-info.component.html b/src/app/user/components/user-profil/user-info/user-info.component.html index 7941452fa2d34a71cbdee1e0ebc2d5aea3672f6b..0ca186e6515e1ec271a5703c9f01a7e51cdb08e4 100644 --- a/src/app/user/components/user-profil/user-info/user-info.component.html +++ b/src/app/user/components/user-profil/user-info/user-info.component.html @@ -10,11 +10,11 @@ (keyup)="toUppercase(userInfoUpdateForm, 'firstName')" [ngClass]="{'has-error': fieldIsInvalid(userInfoUpdateForm, 'firstName'), 'is-valid': fieldIsValid(userInfoUpdateForm, 'firstName')}"> <span class="icon is-small is-right is-icon-success" *ngIf="fieldIsValid(userInfoUpdateForm, 'firstName')"> - <i class="fas fa-check-circle"></i> + <span class="fas fa-check-circle"></span> </span> <span class="icon is-small is-right is-icon-warning" *ngIf="fieldIsInvalid(userInfoUpdateForm, 'firstName')"> - <i class="fas fa-exclamation-circle"></i> + <span class="fas fa-exclamation-circle"></span> </span> </p> @@ -38,10 +38,10 @@ (keyup)="toUppercase(userInfoUpdateForm,'lastName')" [ngClass]="{'has-error': fieldIsInvalid(userInfoUpdateForm, 'lastName'), 'is-valid': fieldIsValid(userInfoUpdateForm, 'lastName')}"> <span class="icon is-small is-right is-icon-success" *ngIf="fieldIsValid(userInfoUpdateForm, 'lastName')"> - <i class="fas fa-check-circle"></i> + <span class="fas fa-check-circle"></span> </span> <span class="icon is-small is-right is-icon-warning" *ngIf="fieldIsInvalid(userInfoUpdateForm, 'lastName')"> - <i class="fas fa-exclamation-circle"></i> + <span class="fas fa-exclamation-circle"></span> </span> </p> @@ -187,4 +187,4 @@ </footer> </div> <button class="modal-close is-large" aria-label="close" (click)="closeDeleteAccountModal()"></button> -</div> \ No newline at end of file +</div>