From a2bfeb904098241cc58d976392e3397913f284a2 Mon Sep 17 00:00:00 2001
From: FORESTIER Fabien <fabien.forestier@soprasteria.com>
Date: Tue, 15 May 2018 16:36:48 +0200
Subject: [PATCH] Add title and underline on Metropolis Website link in footer
---
webapp/src/app/core/components/footer/footer.component.html | 4 ++--
webapp/src/app/core/components/footer/footer.component.scss | 4 ++++
webapp/src/i18n/messages.en.xlf | 4 ++++
webapp/src/i18n/messages.fr.xlf | 4 ++++
4 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/webapp/src/app/core/components/footer/footer.component.html b/webapp/src/app/core/components/footer/footer.component.html
index 7acd04f4..729c18e9 100644
--- a/webapp/src/app/core/components/footer/footer.component.html
+++ b/webapp/src/app/core/components/footer/footer.component.html
@@ -40,11 +40,11 @@
<ul>
<li>
<a href="https://www.grandlyon.com/" target="_blank">
- <img class="plus-logo" src="./assets/img/footer-plus.png" alt="plus-logo">
+ <img i18n-title="@@footer.metropole.site.title" title="Access the Lyon Metropolis website (new window)" class="plus-logo" src="./assets/img/footer-plus.png" alt="plus-logo">
</a>
</li>
<li>
- <a href="https://www.grandlyon.com/" target="_blank" i18n="@@footer.metropole.site">
+ <a class="metropolis-website-link" i18n-title="@@footer.metropole.site.title" title="Access the Lyon Metropolis website (new window)" href="https://www.grandlyon.com/" target="_blank" i18n="@@footer.metropole.site">
A Lyon Metropolis website
</a>
</li>
diff --git a/webapp/src/app/core/components/footer/footer.component.scss b/webapp/src/app/core/components/footer/footer.component.scss
index 5f488cbd..a0919ffc 100644
--- a/webapp/src/app/core/components/footer/footer.component.scss
+++ b/webapp/src/app/core/components/footer/footer.component.scss
@@ -28,4 +28,8 @@ ul {
.plus-logo {
height: 14px;
+}
+
+.metropolis-website-link:hover {
+ text-decoration: underline;
}
\ No newline at end of file
diff --git a/webapp/src/i18n/messages.en.xlf b/webapp/src/i18n/messages.en.xlf
index 7fe7c6fd..4de485c7 100644
--- a/webapp/src/i18n/messages.en.xlf
+++ b/webapp/src/i18n/messages.en.xlf
@@ -34,6 +34,10 @@
<source>A Lyon Metropolis' website</source>
<target>A Lyon Metropolis' website</target>
</trans-unit>
+ <trans-unit id="footer.metropole.site.title" datatype="html">
+ <source>Access the Lyon Metropolis website (new window)</source>
+ <target>Access the Lyon Metropolis website (new window)</target>
+ </trans-unit>
<trans-unit id="header.logoEnglish" datatype="html">
<source>English</source>
<target>English</target>
diff --git a/webapp/src/i18n/messages.fr.xlf b/webapp/src/i18n/messages.fr.xlf
index bc259241..3c98bfbd 100644
--- a/webapp/src/i18n/messages.fr.xlf
+++ b/webapp/src/i18n/messages.fr.xlf
@@ -34,6 +34,10 @@
<source>A Lyon Metropolis website</source>
<target>Un site de la métrople de Lyon</target>
</trans-unit>
+ <trans-unit id="footer.metropole.site.title" datatype="html">
+ <source>Access the Lyon Metropolis website (new window)</source>
+ <target>Accéder au site de la Métropole de Lyon (nouvelle fenêtre)</target>
+ </trans-unit>
<trans-unit id="header.logoEnglish" datatype="html">
<source>English</source>
<target>Anglais</target>
--
GitLab