Skip to content

Resolve "[?] Rédaction lettre mensuelle - Pouvoir centrer les images insérées dans le backoffice - SPIKE"

Rémi PAILHAREY requested to merge 14-redaction-lettre-mensuelle-pouvoir-centrer-les-images-inserees-dans-le-backoffice-spike into dev
🚩 Give your MR the same name that the desired squash commit. In doubt, check the conventional commit doc.

What does this MR do and why?

Resolves #14 (closed)

⚠ Keep an up to date checklist based on your icescrum tasks during all the draft phase of the MR to help any other developer who would take the job after you to finish it.

Screenshots or screen recordings

image

How to set up and validate locally (or on alpha)

  • ⚠ Update your dependencies yarn
  • Launch project yarn local-up
  • Connect to the newsletter editor and write content including images (image icon in the toolbar) in one of the sections for March month
  • You can select image alignment by hovering it and selecting L, C or R
  • Save your section
  • You can get the data stored by the backoffice by calling https://localhost/api/common/monthlyReport?year=2023&month=3
  • Copy this response
  • Open Ecolyo project
  • Replace the lines 147-154 of src/targets/services/monthlyReportNotification.ts by the response you copied above
  • Start the local stack docker compose up -d
  • Build the app yarn build-dev
  • Trigger the newsletter service yarn run cozy-konnector-dev -m ./manifest.webapp ./build/services/monthlyReportNotification/ecolyo.js
  • Go to localhost:8025
  • You should see your newsletter with properly aligned images

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • Confirmed
  1. For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  2. I have made sure that the sonar quality coverage is up to standards.
  3. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  4. I have tested this MR in all supported browsers or determined that this testing is not needed.
  5. I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • Confirmed
  1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  2. I have considered the scalability risk based on future predicted growth.

Documentation

  • Confirmed
  1. The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  2. I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security

  • Confirmed
  1. I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • Confirmed
  1. When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Related to #14 (closed)

Edited by Rémi PAILHAREY

Merge request reports