feat: randomize cron seconds for triggers

src/services/fluidConfig.service.spec.ts

@@ -9,11 +9,21 @@ describe('ConfigService service', () => {
     })
   })
   describe('getCronArgs', () => {
-    it('should return the args of a cron', () => {
-      const max = 5
-      const min = 5
+    it('should return minimum cron', () => {
+      const min = 7
+      const max = 9
+      jest.spyOn(configService, 'random').mockReturnValue(0)
+
+      const result = configService.getCronArgs(min, max)
+      expect(result).toEqual(`0 0 ${min} * * *`)
+    })
+    it('should return maximum cron', () => {
+      const min = 7
+      const max = 9
+      jest.spyOn(configService, 'random').mockReturnValue(0.9999)
+
       const result = configService.getCronArgs(min, max)
-      expect(typeof result).toEqual('string')
+      expect(result).toEqual(`59 59 ${max} * * *`)
     })
   })
 })

src/services/fluidConfig.service.ts

@@ -6,14 +6,20 @@ export default class ConfigService {
     return Config.fluidConfig as FluidConfig[]
   }
 
+  // Wrapping Math.random for testing purposes
+  public random(): number {
+    return Math.random()
+  }
+
   /**
    *
    * @param min Minimum hour for cron
    * @param max Maximum hour for cron
    */
   public getCronArgs(min = 8, max = 9): string {
-    const randomHour = Math.floor(Math.random() * (max - min + 1) + min) // NOSONAR
-    const randomMinutes = Math.floor(Math.random() * 59) // NOSONAR
-    return `0 ${randomMinutes} ${randomHour} * * *`
+    const randomHour = Math.floor(this.random() * (max - min + 1) + min) // NOSONAR
+    const randomMinutes = Math.floor(this.random() * 60) // NOSONAR
+    const randomSeconds = Math.floor(this.random() * 60) // NOSONAR
+    return `${randomSeconds} ${randomMinutes} ${randomHour} * * *`
   }
 }

src/services/triggers.service.ts

@@ -25,7 +25,7 @@ export default class TriggerService {
 
   private createTriggerAttributes(account: Account, konnector: Konnector) {
     const configService = new ConfigService()
-    const cronArgs = configService.getCronArgs()
+    const cronArgs = configService.getCronArgs(7, 9)
     const triggerAttributes: TriggerAttributes = buildAttributes({
       account: account,
       cron: cronArgs,