Skip to content
Snippets Groups Projects
Commit 2ade1f65 authored by Bastien DUMONT's avatar Bastien DUMONT :angel:
Browse files

Merge branch 'lint/leaked-rendering' into 'dev'

chore(lint): fix leaked rendering

See merge request !1255
parents acdc14ee 45a5c65b
Branches
No related tags found
1 merge request!1255chore(lint): fix leaked rendering
......@@ -78,6 +78,7 @@ module.exports = {
'@eslint-react/dom/no-dangerously-set-innerhtml': 0, // used for for injecting html tags
'@eslint-react/no-array-index-key': 0,
'@eslint-react/no-unused-class-component-members': 0, // disabled for ".d.ts" files
'@eslint-react/no-leaked-conditional-rendering': 'error', // important ! avoids rendering 0
},
},
{
......
......@@ -293,9 +293,7 @@ const Bar = ({
/>
</g>
) : (
height > 0 &&
dataload.value &&
dataload.value >= 0 && (
Boolean(height > 0 && dataload.value && dataload.value >= 0) && (
// default colored bar
<g
className="barValue"
......
......@@ -97,7 +97,7 @@ const ProfileTypeOptions = () => {
<div className="value">
{t(`profile_type.housing_type.${profileType.housingType}`)}
</div>
{profileType.constructionYear && (
{Boolean(profileType.constructionYear) && (
<div className="value">
{t(
`profile_type.construction_year.${
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment