notif disapear on modal open + filter

src/components/ContainerComponents/ViewContainer/FinishedChallengeDetailsViewContainer.tsx

@@ -160,12 +160,14 @@ const FinishedChallengeDetailsViewContainer: React.FC<FinishedChallengeDetailsVi
                 </div>
               </div>
             </div>
-            <EcogestureModal
-              opened={openEcogestureModal}
-              ecogesture={challenge.selectedEcogestures[challengeEcogesture]}
-              handleCloseClick={handleCloseClick}
-              unlockedEcogesture={true}
-            />
+            {openEcogestureModal && (
+              <EcogestureModal
+                opened={openEcogestureModal}
+                ecogesture={challenge.selectedEcogestures[challengeEcogesture]}
+                handleCloseClick={handleCloseClick}
+                unlockedEcogesture={true}
+              />
+            )}
           </>
         )}
       </Content>

src/components/ContainerComponents/ViewContainer/OngoingChallengeDetailsViewContainer.tsx

@@ -38,9 +38,12 @@ const OngoingChallengeDetailsViewContainer: React.FC<OngoingChallengeDetailsView
   const client = props.client
   const challengeManager = new ChallengeManager(client)
 
-  const { refreshCurrentChallenge, screenType, userProfile } = useContext(
-    AppContext
-  )
+  const {
+    refreshCurrentChallenge,
+    screenType,
+    userProfile,
+    setNotificationEcogesture,
+  } = useContext(AppContext)
   const [challengeEcogesture, setChallengeEcogesture] = useState<number>(0)
   const [openEcogestureModal, setOpenEcogestureModal] = useState(false)
   const [challenge, setChallenge] = useState<UserChallenge | null>(null)
@@ -57,7 +60,18 @@ const OngoingChallengeDetailsViewContainer: React.FC<OngoingChallengeDetailsView
         challenge.id,
         ChallengeState.ABANDONED
       )
-      userProfile.notificationEcogesture = []
+
+      userProfile.notificationEcogesture =
+        userProfile &&
+        userProfile.notificationEcogesture.filter(
+          x =>
+            x !== challenge.selectedEcogestures[0].id &&
+            x !== challenge.selectedEcogestures[1].id
+        )
+      await setNotificationEcogesture(
+        userProfile && userProfile.notificationEcogesture
+      )
+
       await refreshCurrentChallenge()
       history.goBack()
     }

src/components/ContentComponents/EcogestureList/EcogestureList.tsx

@@ -19,7 +19,6 @@ const EcogesturesList: React.FC<EcogesturesListProps> = ({
   t,
   client,
 }: EcogesturesListProps) => {
-  const { userProfile, setNotificationEcogesture } = useContext(AppContext)
   const [
     selectedEcogesture,
     setSelectedEcogesture,
@@ -32,14 +31,6 @@ const EcogesturesList: React.FC<EcogesturesListProps> = ({
   const handleClick = (ecogesture: EcogestureType) => {
     setSelectedEcogesture(ecogesture)
     setOpenEcogestureModal(true)
-    let index = -1
-    index = userProfile.notificationEcogesture.indexOf(ecogesture.id)
-    if (index > -1) {
-      const updatedNotificationEcogestureList =
-        userProfile && userProfile.notificationEcogesture
-      updatedNotificationEcogestureList.splice(index, 1)
-      setNotificationEcogesture(updatedNotificationEcogestureList)
-    }
   }
 
   const handleCloseClick = () => {

src/components/ContentComponents/EcogestureModal/EcogestureModal.tsx

-import React, { useState, useEffect } from 'react'
+import React, { useState, useEffect, useContext } from 'react'
 import { translate } from 'cozy-ui/react/I18n'
 import Modal from 'components/CommonKit/Modal/Modal'
 import { getPicto } from 'utils/utils'
@@ -6,6 +6,7 @@ import { EcogestureType } from 'services/dataChallengeContracts'
 import StyledIcon from 'components/CommonKit/Icon/StyledIcon'
 import Icon from 'cozy-ui/react/Icon'
 import def from 'assets/icons/visu/ecogesture/default.svg'
+import { AppContext } from 'components/Contexts/AppContextProvider'
 
 interface EcogestureModalProps {
   opened: boolean
@@ -24,6 +25,7 @@ const EcogestureModal: React.FC<EcogestureModalProps> = ({
   handleCloseClick,
 }: EcogestureModalProps) => {
   const [ecogestureIcon, setEcogestureIcon] = useState(def)
+  const { userProfile, setNotificationEcogesture } = useContext(AppContext)
 
   async function importEcogestureIcon(id: string) {
     // Les svg doivent être au format id.svg
@@ -38,6 +40,17 @@ const EcogestureModal: React.FC<EcogestureModalProps> = ({
     }
   }
 
+  useEffect(() => {
+    let index = -1
+    index = userProfile.notificationEcogesture.indexOf(ecogesture.id)
+    if (index > -1) {
+      const updatedNotificationEcogestureList =
+        userProfile && userProfile.notificationEcogesture
+      updatedNotificationEcogestureList.splice(index, 1)
+      setNotificationEcogesture(updatedNotificationEcogestureList)
+    }
+  }, [])
+
   useEffect(() => {
     if (ecogesture) {
       importEcogestureIcon(ecogesture.id)

src/services/queryRunnerService.ts

@@ -211,8 +211,6 @@ export class QueryRunner {
   ) {
     const doctype = this.getRelevantDoctype(fluidType, timeStep)
     if (timeStep === TimeStep.HALF_AN_HOUR) {
-      const lastDayOfPreviousMonth = maxTimePeriod.startDate.plus({ day: -1 })
-
       return this._client
         .find(doctype)
         .where(this.getPredicate(maxTimePeriod, 20))