Skip to content
Snippets Groups Projects
Commit d728db57 authored by Bastien DUMONT's avatar Bastien DUMONT :angel:
Browse files

Merge branch 'chore/remove-get-old-fluid' into 'dev'

chore: remove unused getOldFluidData

See merge request !1232
parents cc891a7b fc55a98f
Branches
Tags
2 merge requests!12413.1 Release,!1232chore: remove unused getOldFluidData
......@@ -529,145 +529,4 @@ describe('Fluid service', () => {
expect(fluidStatus[2].maintenance).toBeTruthy()
})
})
describe('getOldFluidData method', () => {
it('should return Electricity as old fluid', async () => {
const mockFluidStatus: FluidStatus[] = [
{
fluidType: FluidType.ELECTRICITY,
status: FluidState.DONE,
maintenance: false,
firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
keepLocalTime: true,
}),
lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
keepLocalTime: true,
}),
connection: {
konnector: konnectorsData[0],
account: accountsData[0],
trigger: triggersData[0],
triggerState: triggerStateData,
shouldLaunchKonnector: false,
isUpdating: false,
konnectorConfig: {
name: 'Enedis',
oauth: false,
slug: FluidSlugType.ELECTRICITY,
siteLink: 'https://mon-compte-client.enedis.fr/',
activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
},
},
},
]
const result = await FluidService.getOldFluidData(mockFluidStatus)
expect(result).toEqual([FluidType.ELECTRICITY])
})
it('should return empty array as lastdatadate < 5 days', async () => {
const mockFluidStatus: FluidStatus[] = [
{
fluidType: FluidType.ELECTRICITY,
status: FluidState.DONE,
maintenance: false,
firstDataDate: DateTime.local().minus({ day: 31 }).setZone('utc', {
keepLocalTime: true,
}),
lastDataDate: DateTime.local().minus({ day: 1 }).setZone('utc', {
keepLocalTime: true,
}),
connection: {
konnector: konnectorsData[0],
account: accountsData[0],
trigger: triggersData[0],
triggerState: triggerStateData,
shouldLaunchKonnector: false,
isUpdating: false,
konnectorConfig: {
name: 'Enedis',
oauth: false,
slug: FluidSlugType.ELECTRICITY,
siteLink: 'https://mon-compte-client.enedis.fr/',
activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
},
},
},
]
const result = await FluidService.getOldFluidData(mockFluidStatus)
expect(result).toEqual([])
})
it('should return empty array as status is NOT_CONNECTED', async () => {
const mockFluidStatus: FluidStatus[] = [
{
fluidType: FluidType.ELECTRICITY,
status: FluidState.NOT_CONNECTED,
maintenance: false,
firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
keepLocalTime: true,
}),
lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
keepLocalTime: true,
}),
connection: {
konnector: konnectorsData[0],
account: accountsData[0],
trigger: triggersData[0],
triggerState: triggerStateData,
shouldLaunchKonnector: false,
isUpdating: false,
konnectorConfig: {
name: 'Enedis',
oauth: false,
slug: FluidSlugType.ELECTRICITY,
siteLink: 'https://mon-compte-client.enedis.fr/',
activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
},
},
},
]
const result: FluidType[] =
await FluidService.getOldFluidData(mockFluidStatus)
expect(result).toEqual([])
})
it('should return empty array as status is KONNECTOR_NOT_FOUND', async () => {
const mockFluidStatus: FluidStatus[] = [
{
fluidType: FluidType.ELECTRICITY,
status: FluidState.KONNECTOR_NOT_FOUND,
maintenance: false,
firstDataDate: DateTime.fromISO('2019-01-01').setZone('utc', {
keepLocalTime: true,
}),
lastDataDate: DateTime.fromISO('2020-01-01').setZone('utc', {
keepLocalTime: true,
}),
connection: {
konnector: konnectorsData[0],
account: accountsData[0],
trigger: triggersData[0],
triggerState: triggerStateData,
shouldLaunchKonnector: false,
isUpdating: false,
konnectorConfig: {
name: 'Enedis',
oauth: false,
slug: FluidSlugType.ELECTRICITY,
siteLink: 'https://mon-compte-client.enedis.fr/',
activation: 'https://mon-compte-particulier.enedis.fr/donnees/',
},
},
},
]
const result: FluidType[] =
await FluidService.getOldFluidData(mockFluidStatus)
expect(result).toEqual([])
})
it('should return empty array', async () => {
const result: FluidType[] = await FluidService.getOldFluidData([])
expect(result).toEqual([])
})
})
})
......@@ -157,31 +157,4 @@ export default class FluidService {
]
return result
}
/**
* Return fluids with data older than 5 days
*/
static getOldFluidData = async (
fluidStatus: FluidStatus[]
): Promise<FluidType[]> => {
const fluidOldData: FluidType[] = []
if (fluidStatus.length > 0) {
for (const fluid of fluidStatus) {
let diffInDays = 0
if (fluid?.lastDataDate) {
const dateToCompare = fluid.lastDataDate
diffInDays = dateToCompare.diffNow('days').toObject().days || 0
if (
diffInDays < -5 &&
fluid.status !== FluidState.KONNECTOR_NOT_FOUND &&
fluid.status !== FluidState.NOT_CONNECTED
) {
!fluidOldData.includes(fluid.fluidType) &&
fluidOldData.push(fluid.fluidType)
}
}
}
}
return fluidOldData
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment