Skip to content
Snippets Groups Projects
Commit fbd49bdd authored by Yoan VALLET's avatar Yoan VALLET
Browse files

feat: return null return for ecogesture service

parent 7e02de11
No related branches found
No related tags found
1 merge request!139Features/unit tests
...@@ -67,10 +67,10 @@ describe('Ecogesture service', () => { ...@@ -67,10 +67,10 @@ describe('Ecogesture service', () => {
const result = await ecogestureService.getAllEcogestures() const result = await ecogestureService.getAllEcogestures()
expect(result).toEqual(mockData) expect(result).toEqual(mockData)
}) })
it('shoud return null when no ecogestures stored', async () => { it('shoud return empty array when no ecogestures stored', async () => {
mockClient.query.mockResolvedValueOnce({ data: null }) mockClient.query.mockResolvedValueOnce({ data: [] })
const result = await ecogestureService.getAllEcogestures() const result = await ecogestureService.getAllEcogestures()
expect(result).toBe(null) expect(result).toEqual([])
}) })
}) })
...@@ -84,7 +84,7 @@ describe('Ecogesture service', () => { ...@@ -84,7 +84,7 @@ describe('Ecogesture service', () => {
expect(result).toBe(true) expect(result).toBe(true)
}) })
it('shoud return true when no ecogestures stored', async () => { it('shoud return true when no ecogestures stored', async () => {
mockClient.query.mockImplementation(() => Promise.resolve({ data: null })) mockClient.query.mockImplementation(() => Promise.resolve({ data: [] }))
const result = await ecogestureService.deleteAllEcogestures() const result = await ecogestureService.deleteAllEcogestures()
expect(result).toBe(true) expect(result).toBe(true)
}) })
......
...@@ -9,18 +9,15 @@ export default class EcogestureService { ...@@ -9,18 +9,15 @@ export default class EcogestureService {
this._client = _client this._client = _client
} }
public async getAllEcogestures(): Promise<Ecogesture[] | null> { public async getAllEcogestures(): Promise<Ecogesture[]> {
const ecogestures = await this._client.query( const ecogestures = await this._client.query(
this._client.find(ECOGESTURE_DOCTYPE) this._client.find(ECOGESTURE_DOCTYPE)
) )
if (!ecogestures) return null
return ecogestures.data return ecogestures.data
} }
public async deleteAllEcogestures(): Promise<boolean> { public async deleteAllEcogestures(): Promise<boolean> {
const ecogestures = await this.getAllEcogestures() const ecogestures = await this.getAllEcogestures()
if (!ecogestures) return true
try { try {
for (let index = 0; index < ecogestures.length; index++) { for (let index = 0; index < ecogestures.length; index++) {
await this._client.destroy(ecogestures[index]) await this._client.destroy(ecogestures[index])
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment