Skip to content
Snippets Groups Projects

fix(analysis): modal no konnector

Merged Bastien DUMONT requested to merge analysis-no-fluid into dev

Related to #496 (closed)

:triangular_flag_on_post: Give your MR title the same name that the desired squash commit. In doubt, check the conventional commit doc. examples
feat(profile): add...
fix(annuaire): remove...

What does this MR do and why?

QA : La page analyse pousse à la connexion => Non, on est sur un mode "Données non disponibles".

Reverthttps://forge.grandlyon.com/web-et-numerique/factory/llle_project/ecolyo/-/merge_requests/923/diffs?commit_id=14defb6b5c2a1e4e56f8f164da415c725743e590

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien DUMONTBastien DUMONT 1 year ago (Sep 27, 2023 3:10pm UTC)

Merge details

  • Changes merged into dev with 0d7def60 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hugo NOUTS
  • Contributor

    pouet

  • Hugo NOUTS requested review from @hnouts

    requested review from @hnouts

  • Bastien DUMONT added 1 commit

    added 1 commit

    Compare with previous version

  • Bastien DUMONT added 1 commit

    added 1 commit

    Compare with previous version

  • Bastien DUMONT added 1 commit

    added 1 commit

    Compare with previous version

  • Bastien DUMONT added 1 commit

    added 1 commit

    • 50686554 - display modal when no data + no konnector

    Compare with previous version

  • Bastien DUMONT added 1 commit

    added 1 commit

    Compare with previous version

  • Hugo NOUTS resolved all threads

    resolved all threads

  • Hugo NOUTS approved this merge request

    approved this merge request

  • Bastien DUMONT mentioned in commit 0d7def60

    mentioned in commit 0d7def60

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading