Skip to content

feat(analysis): off-peak hours ratio

Rémi PAILHAREY requested to merge feat/hp-hc-ratio into dev

Related to [5] L'utilisateur bénéficie d'une analyse de sa... (#565 - closed)

🚩 Give your MR title the same name that the desired squash commit. In doubt, check the conventional commit doc. examples
feat(profile): add...
fix(annuaire): remove...

What does this MR do and why?

This MR also include local scripts updates and typo fixes

Update your scripts/config.js file to match the attribute names in scripts/config.template.js (to fit camelCase)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

Locally, edit your sge account in DB to add offPeakHours

run yarn build and yarn run cozy-konnector-dev -m manifest.webapp ./build/services/enedisHalfHourMonthlyAnalysis/ecolyo.js to launch the service that process half-hour analysis

Check the analysis page to see the ratio and open the modal to check if the off-peak hours are displayed

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Related to #565 (closed)

Edited by Rémi PAILHAREY

Merge request reports

Loading