Skip to content
Snippets Groups Projects

chore(ui): avoid useless dispatch

Merged Bastien DUMONT requested to merge fix/layout-dispatch into dev
All threads resolved!

Related to #000

:triangular_flag_on_post: Give your MR title the same name that the desired squash commit. Check the conventional commit documentation. Examples :
feat(profile): add...
fix(annuaire): remove...

What does this MR do and why?

This MR avoids dispatching in batch :

  • when resizing the window

image

  • when switching page, setHeader was called even if there was no change to commit

image

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Follow the conventional comments for easier communication and intention !

Quality

Bugs & smells summary

:repeat: Re-run Quality job to update

Current MR Dev
Bugs Bugs
Code Smells Code Smells

Quality checklist

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor

    praise :pray: : Your changes look great!

    Your changes significantly enhance readability and maintainability, ensuring consistency and optimizing performance.

  • Ghost User approved this merge request

    approved this merge request

  • Ghost User resolved all threads

    resolved all threads

  • merged

  • Bastien DUMONT mentioned in commit 814d9cfd

    mentioned in commit 814d9cfd

  • Author Contributor

    This caused a crash in local. I reverted this commit. I'll take a look at it

  • Bastien DUMONT mentioned in merge request !1172 (merged)

    mentioned in merge request !1172 (merged)

  • Please register or sign in to reply
    Loading