Resolve "[DACC] - Les variations de consommation sont inversées"
What does this MR do and why?
Correct issue on consumption variation calculation sign
|
---|
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally (or on alpha)
- Procédure de validation mail :
Ceci est lié a un problème sur le backoffice de recette
- Réaliser le test
yarn build-dev
yarn run cozy-konnector-dev -m manifest.webapp build/services/monthlyReportNotification/ecolyo.js
- Valider le mail a l'url suivante : http://localhost:8025/
- Procédure de test du dacc : https://doc.self-data.alpha.grandlyon.com/ecolyo/functionalities/dacc/#how-to-local-test
MR acceptance checklist
-
Valider que le % de baisse ou d'augmentation est le bon du mois a l'autre http://ecolyo.cozy.tools:8080/#/analysis -
Valider que l'envoi de mail possède le bon signe d'augmentation/baisse -
Valider le signe avec l'envoi au dacc
Quality
-
Confirmed
- For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
- I have made sure that the sonar quality coverage is up to standards.
- I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
- I have tested this MR in all supported browsers or determined that this testing is not needed.
- I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.
Performance, reliability and availability
-
Confirmed
- I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
- I have considered the scalability risk based on future predicted growth.
Documentation
-
Confirmed
- I have prepared a squash commit to feed the changelog linked to the current milestone.
- I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.
Security
-
Confirmed
- I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.
Deployment
-
Confirmed
- When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Closes #263 (closed)
Edited by Yoan VALLET