Skip to content

Feat/us816 sge new connect ui

Guilhem CARRON requested to merge feat/US816-SGE-new-connect-ui into dev
🚩 Give your MR the same name that the desired squash commit. In doubt, check the conventional commit doc.

What does this MR do and why?

This MR implements the new SGE konnector.

Retours PO :

  • Il manque la 1/2h sur la démo.
  • Lorsqu’un code postal est faux, la modale d’erreur dit “J’y vais” au lieu de “J’ai compris”
  • Lorsque j’efface mon PDL s’il était pré-rempli, le bouton suivant ne s’enleve pas
  • Lorsqu’il y’a une erreur de correspondance, la modale d’erreur n’est pas la bonne
  • Disable bouton next si on a cliqué sur précédent et que le formulaire n'est plus valide
  • Test de non-regression sur GRDF

Screenshots or screen recordings

Wrong ZipCode Wrong PDL Login Failed
image image image

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality

  • Confirmed
  1. For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  2. I have made sure that the sonar quality coverage is up to standards.
  3. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  4. I have tested this MR in all supported browsers or determined that this testing is not needed.
  5. I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • Confirmed
  1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  2. I have considered the scalability risk based on future predicted growth.

Documentation

  • Confirmed
  1. The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  2. I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security

  • Confirmed
  1. I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • Confirmed
  1. When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Bastien DUMONT

Merge request reports