Skip to content

fix(alert): fix water consumption alert

Guilhem CARRON requested to merge fix/US867-water-consumption-alert into dev
🚩 Give your MR the same name that the desired squash commit. In doubt, check the conventional commit doc.

What does this MR do and why?

This MR fixes the consumption alert.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

In order to test it, setup an alert in your options. (make sure you have water konnector up and a low value in order to trigger the alert).

  • Build your app with yarn build-dev
  • launch the service : yarn run cozy-konnector-dev -m manifest.webapp build/services/consumptionAlert/ecolyo.js
  • Open MailHog and make sure you received the mail

On alpha :

  • Deploy the branch on your instance and setup an alert
  • Make sure you have an email address in your cozy settings
  • Run command ./get_instance_triggers.sh yourinstance
  • Select the right service id (the one with a @cron 0 3 * * *)
  • Launch it with ./launch_instance_trigger.sh yourinstance triggerId

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • Confirmed
  1. For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  2. I have made sure that the sonar quality coverage is up to standards.
  3. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  4. I have tested this MR in all supported browsers or determined that this testing is not needed.
  5. I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • Confirmed
  1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  2. I have considered the scalability risk based on future predicted growth.

Documentation

  • Confirmed
  1. The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  2. I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • Confirmed
  1. I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • Confirmed
  1. When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Guilhem CARRON

Merge request reports