Skip to content

Resolve "[SGE+ Export de données] Export de données électricité KO"

Rémi PAILHAREY requested to merge 300-sge-export-de-donnees-export-de-donnees-electricite-ko into dev

What does this MR do and why?

Bug en prod Canary, l'électricité n'apparaît pas dans les options d'export de données (+ d'infos sur l'issue #300 (closed))

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

Le problème de Marion venait du fait qu'elle avait une ligne dans la table enedis.month qui avait des valeurs de year et month à null. (Probablement un problème d'import/export ACH 😅)

Je vais corriger son problème en prod en supprimant cette données erronée mais j'ai ajouté une vérification pour que ce problème n'apparaisse pas chez quelqu'un autre (même s'il ne devrait pas)

Pour constater le problème et vérifier que le fix fonctionne :

  • Se placer sur la branche dev
  • Changer dans la couchDB la valeur d'une entrée de la table enedis.month de façon à avoir year et/ou month à null
  • Depuis la page options, on ne peut pas télécharger l'électricité
  • Se placer sur la branche 300-sge-export-de-donnees-export-de-donnees-electricite-ko
  • Exporter les données depuis la page options

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Related to #300 (closed)

Edited by Rémi PAILHAREY

Merge request reports