Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Ecolyo Ecolyo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • web-et-numerique
  • Factory
  • LLLE_Project
  • EcolyoEcolyo
  • Merge requests
  • !788

Resolve "[?] Comprendre que le connecteur est en maintenance même lorsque je suis déconnecté"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bastien DUMONT requested to merge 342-connecteur-maintenance-deconnecte into dev Jan 03, 2023
  • Overview 3
  • Commits 31
  • Pipelines 16
  • Changes 33

What does this MR do and why?

Mise à jour des modales de maintenance pour chaque fluide:

image

Ajout de l'icone maintenance meme si le fluide est déconnecté

image

How to set up and validate locally (or on alpha)

Ecolyo agent rec / Settings

  • vérifier la suppression de l'ancienne valeur partnersIssueDate dans le doctype profil (migration 22)
avant après
"partnersIssueDate": "2023-01-10T23:00:00.000Z", image
  • avoir une modale par jour par fluide (x3)
  • Tester différents état de fluides :
    • connectés -> affichage des modales
    • non connecté -> pas de modale mais icone sur le fluide concerné

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.

Related to #342 (closed)

Edited Jan 12, 2023 by Hugo NOUTS
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 342-connecteur-maintenance-deconnecte