Merge branch 'fix/terms_version_mismatch_error' into 'dev'

fix: TERMS_VERSION_MISMATCH error

See merge request !55

__tests__/core/verifyUserIdentity.spec.js

@@ -39,7 +39,7 @@ describe('verifyUserIdentity', () => {
     }
   })
 
-  it('should throw TERMS_VERSION_MISMATCH when pdl give and received are NOT matching on alternate start 🚫', async () => {
+  it('should throw USER_ACTION_NEEDED_PERMISSIONS_CHANGED when pdl give and received are NOT matching on alternate start 🚫', async () => {
     findUserPdl.mockResolvedValueOnce('12345')
     try {
       await verifyUserIdentity(
@@ -56,7 +56,7 @@ describe('verifyUserIdentity', () => {
       )
       expect(true).toBe(false)
     } catch (error) {
-      expect(error.message).toBe(errors.TERMS_VERSION_MISMATCH)
+      expect(error.message).toBe(errors.USER_ACTION_NEEDED_PERMISSIONS_CHANGED)
     }
   })
 

src/core/verifyUserIdentity.js

@@ -67,7 +67,7 @@ async function verifyUserIdentity(
       userAddress.escalierEtEtageEtAppartement
         ? removeMultipleSpaces(userAddress.escalierEtEtageEtAppartement)
         : ''
-
+    // Second try, trim whitespace
     pdl = await findUserPdl(
       `${baseUrl}/enedis_SDE_recherche-point/1.0`,
       apiAuthKey,
@@ -134,13 +134,15 @@ async function verifyUserIdentity(
     log('error', 'PointId does not match')
 
     if (isAlternateStart) {
-      Sentry.captureException('PointId does not match: Alternate start', {
+      Sentry.captureException('PointId no longer match', {
         tags: { section: 'verifyUserIdentity' },
+        extra: { foundPdl: pdl },
       })
-      throw new Error(errors.TERMS_VERSION_MISMATCH)
+      throw new Error(errors.USER_ACTION_NEEDED_PERMISSIONS_CHANGED)
     } else {
       Sentry.captureException('PointId does not match', {
         tags: { section: 'verifyUserIdentity' },
+        extra: { foundPdl: pdl },
       })
       throw new Error(errors.LOGIN_FAILED)
     }