Skip to content
Snippets Groups Projects

fix: throw vendor down when request is rejected

Merged Bastien DUMONT requested to merge fix/unexpected-tag into dev
All threads resolved!

Related to #34 (closed)

:triangular_flag_on_post: Give your MR title the same name that the desired squash commit. In doubt, check the conventional commit doc. examples
feat(profile): add...
fix(annuaire): remove...

What does this MR do and why?

How to reproduce

  • Spam the konnector until you notice the error

When encountering the error you should see

image

instead of weird error from parsing

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Bastien DUMONT

Merge request reports

Merge request pipeline #93833 passed

Merge request pipeline passed for 2df90c7c

Test coverage 93.71% from 1 job
Deployed to d‎ev‎ 1 year ago

Merged by Bastien DUMONTBastien DUMONT 1 year ago (Feb 27, 2024 2:23pm UTC)

Loading

Pipeline #93840 passed

Pipeline passed for a3ec6009 on dev

Deployed to ecoly‎odemo‎ 1 year ago
Deployed to d‎ev‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Contributor

    I will remove the "VENDOR_DOWN" error otherwise we will get flooded. The konnector can some retreive data and still encounter the error

    image

  • Bastien DUMONT added 2 commits

    added 2 commits

    Compare with previous version

  • Bastien DUMONT requested review from @rpailharey

    requested review from @rpailharey

  • Author Contributor

    Sorry I forgot this MR

  • Rémi PAILHAREY resolved all threads

    resolved all threads

  • Rémi PAILHAREY approved this merge request

    approved this merge request

  • Bastien DUMONT mentioned in commit a3ec6009

    mentioned in commit a3ec6009

  • merged

  • Please register or sign in to reply
    Loading