Skip to content
Snippets Groups Projects
Commit b761be8a authored by Hugo SUBTIL's avatar Hugo SUBTIL
Browse files

fix: sonar issues. Unused imports, empty block ...

parent b57e3d45
No related branches found
No related tags found
2 merge requests!68Recette,!67Dev
Showing with 19 additions and 45 deletions
import { Component, OnInit } from '@angular/core';
import { Observable } from 'rxjs';
import { mergeMap } from 'rxjs/operators';
const { DateTime } = require('luxon');
import * as _ from 'lodash';
......@@ -98,7 +96,7 @@ export class HomeComponent implements OnInit {
* @param value string
*/
private isLocationRequest(value: string): boolean {
const regex = /^\d+\s[A-z]+\s[A-z]+/g;
const regex = /^\d+\s[A-z]+\s[A-z]+/g; //NOSONAR
if (value.match(regex)) {
return true;
}
......
......@@ -8,23 +8,8 @@ import {
SimpleChanges,
ViewChild,
} from '@angular/core';
import {
latLng,
MapOptions,
tileLayer,
Map,
CRS,
TileLayer,
LatLngBounds,
latLngBounds,
Marker,
layerGroup,
polyline,
} from 'leaflet';
import { Observable } from 'rxjs';
import { mergeMap } from 'rxjs/operators';
import { latLng, MapOptions, tileLayer, Map, CRS, TileLayer, LatLngBounds, latLngBounds, layerGroup } from 'leaflet';
import { Structure } from '../../models/structure.model';
import { GeoJson } from '../models/geojson.model';
import { GeojsonService } from '../../services/geojson.service';
import { MapService } from '../services/map.service';
import { NgxLeafletLocateComponent } from '@runette/ngx-leaflet-locate';
......
import { TestBed } from '@angular/core/testing';
import { Map } from 'leaflet';
import { MapService } from './map.service';
......
import { TestBed } from '@angular/core/testing';
import { Address } from '../models/address.model';
import { GeojsonService } from './geojson.service';
import { HttpClientModule } from '@angular/common/http';
......
import { HttpClient, HttpHeaders } from '@angular/common/http';
import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { Observable } from 'rxjs';
import { map } from 'rxjs/operators';
import { Address } from '../models/address.model';
import { GeoJson } from '../map/models/geojson.model';
import * as _ from 'lodash';
......
import { HttpClientTestingModule } from '@angular/common/http/testing';
import { inject, TestBed } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { Day } from '../models/day.model';
import { Structure } from '../models/structure.model';
import { Time } from '../models/time.model';
......
......@@ -19,11 +19,10 @@ export class LogoCardComponent implements OnInit {
// Get the custom or default name from a demarche.
public getName(demarche: string): string {
switch (demarche) {
case Demarches.caf:
return 'Caf';
default:
return demarche;
if (demarche === Demarches.caf) {
return 'Caf';
} else {
return demarche;
}
}
public getLogoKey(demarche: string): string {
......
......@@ -104,7 +104,7 @@ describe('SearchComponent', () => {
const checkedModules: Module[] = [{ id: evt.target.value, text: categ, count: 0 }];
component.checkedModulesFilter = checkedModules;
component.numericPassCheck(evt, categ);
const expectArray: Module[] = [new Module(evt.target.value, categ)];
new Module(evt.target.value, categ);
expect(component.checkedModulesFilter.length).toEqual(0);
expect(component.numberMoreFiltersChecked).toEqual(0);
});
......
import { Component, EventEmitter, OnInit, Output, Type } from '@angular/core';
import { Component, EventEmitter, OnInit, Output } from '@angular/core';
import { FormBuilder, FormGroup } from '@angular/forms';
import { forkJoin } from 'rxjs';
import { GeoJson } from '../../../map/models/geojson.model';
......
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { StyleUtils } from '@angular/flex-layout';
import { OpeningDay } from '../models/openingDay.model';
import { Structure } from '../models/structure.model';
import { Filter } from './models/filter.model';
......
import { Component, EventEmitter, Input, OnInit, Output, OnChanges, SimpleChanges } from '@angular/core';
import { Component, EventEmitter, Input, Output, OnChanges, SimpleChanges } from '@angular/core';
import { Filter } from './models/filter.model';
import { Structure } from '../models/structure.model';
import { GeoJson } from '../map/models/geojson.model';
......@@ -64,8 +64,6 @@ export class StructureListComponent implements OnChanges {
}
public onScrollDown(event): void {
if (event.target.offsetHeight + event.target.scrollTop >= event.target.scrollHeight - 100) {
}
if (event.target.offsetHeight + event.target.scrollTop >= event.target.scrollHeight - 50) {
this.loadMoreStructures();
}
......
......@@ -2,24 +2,22 @@
import 'zone.js/dist/zone-testing';
import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';
import { BrowserDynamicTestingModule, platformBrowserDynamicTesting } from '@angular/platform-browser-dynamic/testing';
declare const require: {
context(path: string, deep?: boolean, filter?: RegExp): {
context(
path: string,
deep?: boolean,
filter?: RegExp
): {
keys(): string[];
<T>(id: string): T;
};
};
// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
context.keys().map(context); //NOSONAR
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment