Skip to content
Snippets Groups Projects

feat/US183-rdv-icon

Merged Marlène SIMONDANT requested to merge feat/US183-rdv-icon into V2.0
:triangular_flag_on_post: Give your MR the same name that the desired squash commit. In doubt, check the conventional commit doc.

What does this MR do and why?

Je peux visualiser les structure avec prise de RDV dans les résultats de la carto Afin de pouvoir accéder à cette information très rapidement.

Lors de résultats dans la carto, les structures contiendront un picto calendrier lorsque le RDV en ligne est possible.

Maquette : https://www.figma.com/file/sTEFbJiag3Klhvx9eO1pvW/R%C3%A9s'in-%5BRecherches%5D?node-id=2225%3A69645

Screenshots or screen recordings

image

image

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Marlène SIMONDANT

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rémi PAILHAREY
  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 1292fef2 - remove width that can cause style pb with short structure names that have rdv

    Compare with previous version

  • Marlène SIMONDANT resolved all threads

    resolved all threads

  • image

    La div contenue dans le app-svg-icon fait 25px de hauteur au lieu de 22px, ce qui crée un espace plus grand entre le nom de la structure et son type si elle a l'icône de rdv. Cependant je ne comprends pas pourquoi elle fait ça... On peut sinon utiliser directement le svg pour ne pas avoir ce problème.

  • added 1 commit

    • 75468324 - force app- svg-icon's div height

    Compare with previous version

  • C'est bon pour moi :wink:

  • Rémi PAILHAREY approved this merge request

    approved this merge request

  • Guilhem CARRON added 1 commit

    added 1 commit

    • 01dcf90c - hide button while rdvs is not ready

    Compare with previous version

  • Guilhem CARRON added 70 commits

    added 70 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading