Skip to content
Snippets Groups Projects

feat(ui) [Orientation] - Replace buttons by tags + search bar

Related to #468 (closed)

What does this MR do and why?

Describe in detail what your merge request does and why.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.


MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Related to #468 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Pierre Ecarlat added 19 commits

    added 19 commits

    Compare with previous version

  • Ghost User
  • Pierre Ecarlat added 13 commits

    added 13 commits

    Compare with previous version

  • added 1 commit

    • 179e61fb - Removed unused class reference in address autocomplete

    Compare with previous version

  • Pierre Ecarlat resolved all threads

    resolved all threads

  • added 1 commit

    • d48d0249 - removed duplicated flex-direction

    Compare with previous version

  • Pierre Ecarlat requested review from @rpailharey

    requested review from @rpailharey

  • added 1 commit

    • d370be06 - Fixed selection of an already selected address

    Compare with previous version

  • Pierre Ecarlat added 2 commits

    added 2 commits

    • 3598d144 - Fixed selection of an already selected address
    • c5b63727 - Merge branch 'feat/orientation/buttons-as-tags' of...

    Compare with previous version

  • Ghost User added 2 commits

    added 2 commits

    • 7fb06620 - review: removed displayedAddress
    • 927a93f5 - Merge branch 'feat/orientation/buttons-as-tags' of...

    Compare with previous version

  • Ghost User resolved all threads

    resolved all threads

  • Ghost User approved this merge request

    approved this merge request

  • Pierre Ecarlat mentioned in commit 4141aff2

    mentioned in commit 4141aff2

  • Please register or sign in to reply
    Loading