Skip to content

refactor(button): remove use of enum

Bastien DUMONT requested to merge refactor/button-type into dev

Related to #427 (closed)

What does this MR do and why?

This MR improves DX by removing the use of variant enums for buttons.

The v3 button was developed the same way we did in v2 but it's less convenient because :

  • you have to import the enum in .ts files to make the enum available in html files
  • we had inconsistent naming of types : buttonTypeV3 buttonTypeEnumV3 buttonTypeV3Enum
  • longer

This MR also removes the default type and mark the input variant as required

Still gives autocompletion :

image

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

Make also sure that storybook works fine


MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.
Edited by Bastien DUMONT

Merge request reports