Skip to content
Snippets Groups Projects

fix(ui): responsive carto list

Merged Bastien DUMONT requested to merge fix/mobile/carto-list into dev
1 unresolved thread

Related to #435 (closed)

What does this MR do and why?

image

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.


MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.
Edited by Bastien DUMONT

Merge request reports

Approved by

Merged by Bastien DUMONTBastien DUMONT 1 year ago (Mar 4, 2024 7:44am UTC)

Merge details

  • Changes merged into dev with 0229ffbb (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • question: I don't think we should add icon-buttons here (?)

    image

    Also, what about the 'Filtrer par' button + filters?

  • Pierre Ecarlat requested review from @pecarlat

    requested review from @pecarlat

  • Bastien DUMONT added 2 commits

    added 2 commits

    Compare with previous version

  • Pierre Ecarlat resolved all threads

    resolved all threads

  • Pierre Ecarlat approved this merge request

    approved this merge request

  • Bastien DUMONT mentioned in commit 0229ffbb

    mentioned in commit 0229ffbb

  • merged

  • Please register or sign in to reply
    Loading