Merge branch...

Merge branch '13-tech-remplacer-par-une-chaine-vide-les-emails-des-structures-aptic-au-lieu-de-unknown-unknown-com' into 'dev'

Resolve "[Tech] remplacer par une chaine vide les emails des structures APTIC (au lieu de unknown@unknown.com )"

See merge request !274

src/migrations/scripts/1678284373613-remove-unknown-emails.ts

+import { Db } from 'mongodb';
+import { StructureDocument } from '../../structures/schemas/structure.schema';
+import { getDb } from '../migrations-utils/db';
+
+export const up = async () => {
+  const db: Db = await getDb();
+  const cursor = db.collection('structures').find({});
+  let document;
+  while ((document = await cursor.next())) {
+    const newDoc: StructureDocument = removeUnknownContactMail(document);
+    await db.collection('structures').updateOne({ _id: document._id }, [{ $set: newDoc }]);
+  }
+  console.log('Update done: Contact emails unknown@unknown.com emptied');
+};
+
+export const down = async () => {
+  // Nothing can be done since we can't know which null contactMail fields were previously filled with unknow@unknown.com
+  console.log('Downgrade done');
+};
+
+function removeUnknownContactMail(doc: StructureDocument): StructureDocument {
+  if (doc.contactMail && doc.contactMail === 'unknown@unknown.com') {
+    doc.contactMail = null;
+  }
+  return doc;
+}

src/structures/services/aptic-structures.service.ts

@@ -80,7 +80,7 @@ export class ApticStructuresService {
         createdStructure.structureName = structure.name;
         createdStructure.contactPhone = structure.phone;
         // Unkown fields (but mandatory)
-        createdStructure.contactMail = 'unknown@unknown.com';
+        createdStructure.contactMail = null;
         createdStructure.categories.labelsQualifications = ['passNumerique'];
         createdStructure.structureType = await this.structureTypeService.findByValue('autre');
         createdStructure.pmrAccess = false;

src/structures/services/structures.service.ts

@@ -275,10 +275,6 @@ export class StructuresService {
         .select('-_id -accountVerified -otherDescription -dataShareConsentDate')
         .exec()
     ).map((structure) => {
-      // If structure has temp email, hide it
-      if (this.hasTempMail(structure)) {
-        structure.contactMail = null;
-      }
       const repositoryKeys = categories.map((category) => category.id);
       repositoryKeys.forEach((el) => {
         // Add referentiel
@@ -937,10 +933,6 @@ export class StructuresService {
     this.mailerService.send(emailsObject, jsonConfig.subject, html);
   }
 
-  private hasTempMail(structure: Structure): boolean {
-    return structure.contactMail === 'unknown@unknown.com';
-  }
-
   public async getAllUserCompletedStructures(users: IUser[]) {
     return Promise.all(
       users.map(async (user) => {