Skip to content

Feat/us135 add lyon arrondissement

Rémi PAILHAREY requested to merge feat/US135-add-lyon-arrondissement into dev

What does this MR do and why?

Ajouter l'arrondissement à la ville de Lyon

Règles :

  • "Lyon 1er" pour premier arrondissement
  • "Lyon 2e", "Lyon 3e", etc... pour les autres

Screenshots or screen recordings

Before After
Screenshot_from_2022-05-25_16-51-30 Screenshot_from_2022-05-25_16-49-20

How to set up and validate locally (or on alpha)

  • Run node ./scripts/init-db and run migrations from 1632750776916-conseillernum-label.ts
  • Delete all structures in database
  • Change cron expression from EVERY_WEEK to EVERY_10_MINUTES in aptic-structures.services.ts, line 184
  • Run npm run start:dev
  • Wait for import to trigger
  • Check that structures are created and that address.commune field in database looks like "Lyon 1er" or "Lyon 2e"
  • Run down migration with npm run migrate:down 1653396510972-format-lyon-arrondissement.ts
  • Check that structures got their original address.commune field
  • Run up migration with npm run migration:up
  • Check that structures got their new formatted address.commune field

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality

  • Confirmed
  1. For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  2. I have made sure that the sonar quality coverage is up to standards.
  3. I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  4. I have tested this MR in all supported browsers or determined that this testing is not needed.
  5. I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • Confirmed
  1. I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  2. I have considered the scalability risk based on future predicted growth.

Documentation

  • Confirmed
  1. I have prepared a squash commit to feed the changelog linked to the current milestone.
  2. I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security

  • Confirmed
  1. I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • Confirmed
  1. When featured on a self-data project release, i have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Rémi PAILHAREY

Merge request reports