feat(admin): show deleted structures
pamn_client#275 (closed)
What does this MR do and why?
http://localhost:3000/api/admin/getDeletedStructures
Describe in detail what your merge request does and why.
![]() |
---|
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally (or on alpha)
List all steps to set up and validate the changes on local environment.
MR acceptance checklist
To be completed by the chosen reviewer.
-
Quality - For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
- I have made sure that the sonar quality coverage is up to standards.
- I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
- I have tested this MR in all supported browsers or determined that this testing is not needed.
- I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.
Performance, reliability and availability
- I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
- I have considered the scalability risk based on future predicted growth.
Documentation
- The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
- I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.
- I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.
Deployment
- When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Merge request reports
Activity
assigned to @bdumont
mentioned in merge request pamn_client!479 (merged)
added 4 commits
-
9e903653...3b046c8f - 2 commits from branch
dev
- eacb11a4 - Merge remote-tracking branch 'origin/dev' into 275-admin-deleted-structures
- 318caf89 - fix tests
-
9e903653...3b046c8f - 2 commits from branch
requested review from @ELOUPIAS
- Resolved by Etienne LOUPIAS
changed milestone to %
[Rés'in] 2.3 - Petites issues disparatesadded 1 commit
- 7c9d19ce - add optional authentication (anonymous guard)
159 159 160 160 @Get(':id') 161 161 @UseGuards(AuthGuard(['jwt', 'anonymous'])) // first success wins (allow anonymous call, req.user is an empty object if user is not authenticated) 162 public async find(@Request() req, @Param('id') id: string) { 162 public async find(@Param('id') id: string, @Request() req = { user: null }) { - Comment on lines 161 to +162
Pas convaincu par ces modifs :
- il me semble que @Request est par convention habituellement en premier paramètre des controllers nest
- si le user n'est pas connecté, il me semble que req.user contient un objet vide (il affiche {} si on le loggue), sinon d'ailleurs req.user.role aurait planté. Donc c'est inutile et plutôt source de confusion de mettre une valeur user à null par défaut alors que ce ne sera jamais le cas (et contradictoire avec le commentaire de la ligne au-dessus)
changed this line in version 11 of the diff
Please register or sign in to reply