Skip to content
Snippets Groups Projects

chore(deps): upgrade nest schedule to v2

Merged Bastien DUMONT requested to merge upgrade-nest-schedule into dev

Related to #000

What does this MR do and why?

v0.4 required nestjs v6 or v7.

I had errors while upgrading node, hopefully this might fix it

# npm resolution error report

While resolving: ram_server@2.3.2
Found: @nestjs/common@9.4.3
node_modules/@nestjs/common
  @nestjs/common@"^9.0.11" from the root project

Could not resolve dependency:
peer @nestjs/common@"^6.10.11 || ^7.0.0" from @nestjs/schedule@0.4.3
node_modules/@nestjs/schedule
  @nestjs/schedule@"^0.4.1" from the root project

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

MR acceptance checklist

To be completed by the chosen reviewer.

Quality Bugs - Code Smells

  • For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
  • I have made sure that the sonar quality coverage is up to standards.
  • I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
  • I have tested this MR in all supported browsers or determined that this testing is not needed.
  • I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

  • I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
  • I have considered the scalability risk based on future predicted growth.

Documentation

  • The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
  • I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security Security Rating

  • I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Deployment

  • When featured on a self-data project release, I have made sure my app version in the manifest and package.json is incremented and any relative changes to the permissions are clearly written and transmitted to Cozy.
Edited by Bastien DUMONT

Merge request reports

Merge request pipeline #70376 passed

Merge request pipeline passed for 5e1abb8c

Merged by Bastien DUMONTBastien DUMONT 1 year ago (Aug 30, 2023 8:27am UTC)

Merge details

  • Changes merged into with 2cb0eff3.
  • Deleted the source branch.

Pipeline #71133 passed

Pipeline passed for 2cb0eff3 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading