Remove unused config variable, add NODE_ENV in gitlab-ci and change container...

Remove unused config variable, add NODE_ENV in gitlab-ci and change container name regarding the env

.gitlab-ci.yml

@@ -19,6 +19,7 @@ build_development:
     - master
     - sandbox
   script:
+    - export NODE_ENV=DEV
     - export NGINX_PORT=8081
     - docker-compose --project-name data-reloaded-dev build --build-arg env=dev nginx-app
 
@@ -28,6 +29,7 @@ deploy_development:
     - master
     - sandbox
   script:
+    - export NODE_ENV=DEV
     - export NGINX_PORT=8081
     - export MATOMO_SITE_ID=1
     - export MATOMO_SERVER_URL=https://matomo-intothesky.alpha.grandlyon.com
@@ -51,6 +53,7 @@ build_staging:
   only:
     - staging
   script:
+    - export NODE_ENV=REC
     - export NGINX_PORT=8080
     - docker-compose --project-name data-reloaded-rec build --build-arg env=rec nginx-app
 
@@ -59,6 +62,7 @@ deploy_staging:
   only:
     - staging
   script:
+    - export NODE_ENV=REC
     - export NGINX_PORT=8080
     - export MATOMO_SITE_ID=3
     - export MATOMO_SERVER_URL=https://matomo-intothesky.alpha.grandlyon.com

docker-compose.yml

@@ -2,7 +2,7 @@ version: "2"
 
 services:
   nginx-app:
-    container_name: nginx-app
+    container_name: nginx-app-${NODE_ENV}
     restart: unless-stopped
     build:
       context: ./

src/environments/environment.dev.ts

@@ -9,7 +9,6 @@ const kongBaseUrl = 'https://kong.alpha.grandlyon.com';
 
 export const environment = {
   production: true,
-  kongUrl: kongBaseUrl,
   oidcLoginEndpoint: kongBaseUrl + '/authentication/dev/login/oidc',
   glcLoginEndpoint: kongBaseUrl + '/authentication/dev/login/glc',
   tokenEndpoint: kongBaseUrl + '/authentication/dev/token',

src/environments/environment.rec.ts

@@ -9,7 +9,6 @@ const kongBaseUrl = 'https://kong.alpha.grandlyon.com';
 
 export const environment = {
   production: true,
-  kongUrl: kongBaseUrl,
   oidcLoginEndpoint: kongBaseUrl + '/authentication/rec/login/oidc',
   glcLoginEndpoint: kongBaseUrl + '/authentication/rec/login/glc',
   tokenEndpoint: kongBaseUrl + '/authentication/rec/token',

src/environments/environment.ts

@@ -9,7 +9,6 @@ const kongBaseUrl = 'https://kong.alpha.grandlyon.com';
 
 export const environment = {
   production: false,
-  kongUrl: kongBaseUrl,
   oidcLoginEndpoint: kongBaseUrl + '/authentication/dev/login/oidc',
   glcLoginEndpoint: kongBaseUrl + '/authentication/dev/login/glc',
   tokenEndpoint: kongBaseUrl + '/authentication/dev/token',