Skip to content
Snippets Groups Projects
Commit aa958e3b authored by Romain CREY's avatar Romain CREY
Browse files

fix: add subscribed on async useEffect

parent bed14fbf
No related branches found
No related tags found
2 merge requests!58Merge master into dev - v0.1.6,!56Resolve "Superposition ecogeste"
...@@ -76,6 +76,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails ...@@ -76,6 +76,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
} }
useEffect(() => { useEffect(() => {
let subscribed = true
const lag = challengeManager.getLagDays(fluidTypes) const lag = challengeManager.getLagDays(fluidTypes)
const timePeriod = { const timePeriod = {
...@@ -94,7 +95,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails ...@@ -94,7 +95,7 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
20, 20,
fluidTypes fluidTypes
) )
if (fetchedPerformanceIndicators) { if (fetchedPerformanceIndicators && subscribed) {
fetchedPerformanceIndicators.forEach(element => { fetchedPerformanceIndicators.forEach(element => {
!element.value ? setLackOfDataForChallenge(true) : null !element.value ? setLackOfDataForChallenge(true) : null
}) })
...@@ -106,6 +107,9 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails ...@@ -106,6 +107,9 @@ const AvailableChallengeDetailsViewContainer: React.FC<AvailableChallengeDetails
if (props.location.state) { if (props.location.state) {
setChallenge(props && props.location.state.challenge) setChallenge(props && props.location.state.challenge)
} }
return () => {
subscribed = false
}
}, []) }, [])
return ( return (
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment